fixed handling of ExternalUserAgent.sfSafariViewController (#548)

MaikuB · Oct 3, 2024 · d8e13aa · d8e13aa
1 parent acaef1f
commit d8e13aa
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/flutter_appauth/CHANGELOG.md b/flutter_appauth/CHANGELOG.md
@@ -1,3 +1,7 @@
+## [8.0.0-dev.2]
+
+* [iOS] Fixed issue [547](https://github.com/MaikuB/flutter_appauth/issues/547) bug where specifying `ExternalUserAgent.sfSafariViewController` was using ephemeral session. Should now properly use the [SFSafariViewController](https://developer.apple.com/documentation/safariservices/sfsafariviewcontroller) APIs
+
 ## [8.0.0-dev.1]
 
 * **Breaking change** Replaced the `preferEphemeralSession` property in the `AuthorizationRequest`, `AuthorizationTokenRequest` and  `EndSessionRequest` classes with `externalUserAgent`. Thanks to the PR from [john-slow](https://github.com/john-slow). `externalUserAgent` is presented by the newly `ExternalUserAgent` enum that has the following values

diff --git a/flutter_appauth/ios/Classes/AppAuthIOSAuthorization.m b/flutter_appauth/ios/Classes/AppAuthIOSAuthorization.m
@@ -170,7 +170,7 @@ @implementation AppAuthIOSAuthorization
         initWithPresentingViewController:rootViewController];
   }
   if ([externalUserAgent integerValue] == SafariViewController) {
-    return [[OIDExternalUserAgentIOSNoSSO alloc]
+    return [[OIDExternalUserAgentIOSSafariViewController alloc]
         initWithPresentingViewController:rootViewController];
   }
   return [[OIDExternalUserAgentIOS alloc]

diff --git a/flutter_appauth/pubspec.yaml b/flutter_appauth/pubspec.yaml
@@ -2,7 +2,7 @@ name: flutter_appauth
 description: This plugin provides an abstraction around the Android and iOS
   AppAuth SDKs so it can be used to communicate with OAuth 2.0 and OpenID
   Connect providers
-version: 8.0.0-dev.1
+version: 8.0.0-dev.2
 homepage: https://github.com/MaikuB/flutter_appauth/tree/master/flutter_appauth
 
 environment: