ESLint: enable no var requires rule #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NearW
added
the
tech
BridgeAR
reviewed
Jun 14, 2020
This reverts commit 28f0054.
…rule' into tech/878/enable-no-var-requires-rule
NearW
changed the title
11 tasks
12 tasks
…le-no-var-requires-rule # Conflicts: # visualization/app/codeCharta/codeCharta.component.spec.ts # visualization/app/codeCharta/codeCharta.component.ts # visualization/app/codeCharta/e2e/logo.e2e.ts # visualization/app/codeCharta/e2e/url.e2e.ts # visualization/app/codeCharta/ui/codeMap/threeViewer/threeOrbitControlsService.ts # visualization/app/codeCharta/ui/fileChooser/fileChooser.component.ts # visualization/app/codeCharta/util/deltaGenerator.ts # visualization/app/codeCharta/util/fileValidator.spec.ts # visualization/app/codeCharta/util/fileValidator.ts # visualization/app/codeCharta/util/reduxHelper.ts # visualization/app/codeCharta/util/scenarioHelper.spec.ts # visualization/app/codeCharta/util/scenarioHelper.ts # visualization/app/puppeteer.helper.ts
NearW
commented
Aug 13, 2020
visualization/app/codeCharta/ui/fileChooser/fileChooser.component.ts
Outdated
Show resolved
Hide resolved
NearW
changed the title
BridgeAR
reviewed
Sep 8, 2020
BridgeAR
approved these changes
Sep 8, 2020
…rule' into tech/878/enable-no-var-requires-rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable no var requires rule
Description
clone.tsand added a wrapper function to clone, since it would require a double method call every time we use it. This should be reverted once rfdc releases a new version.