New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Old mcc maps can be migrated to new metric names #3685 #3803

Merged

polina-schoenfeld-mw merged 4 commits into main from feat/3685/migrate-old-mcc-maps

Oct 28, 2024

Contributor

polina-schoenfeld-mw commented Oct 25, 2024 •

edited

Loading

Old mcc maps can be migrated to new metric names

Closes: #3685

Description

Add additional check for mcc metric before removing it

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

Changes have been manually tested
All TODOs related to this PR have been closed
There are automated tests for newly written code and bug fixes
All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
CHANGELOG.md has been updated

polina-schoenfeld-mw added 3 commits

October 25, 2024 15:17


          fix(analysis): check if "mcc" key exists before removing it and simpl…

768021f

…ify code


          chore(analysis): add space

6e155b5


          Merge branch 'main' into feat/3685/migrate-old-mcc-maps

93da664

phanlezz approved these changes

View reviewed changes

Collaborator

phanlezz left a comment

LGTM :) Don't forget the changelog


          chore(visualization): update changelog

a350dfe

sonarqubecloud bot commented Oct 28, 2024

Quality Gate passed for 'CodeCharta Visualization'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud bot commented Oct 28, 2024

Quality Gate passed for 'CodeCharta Analysis'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
33.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

polina-schoenfeld-mw merged commit f6e07d6 into main

7 checks passed

polina-schoenfeld-mw deleted the feat/3685/migrate-old-mcc-maps branch

October 28, 2024 11:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet