Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/3780/buildings without area #3789

Merged
merged 16 commits into from
Oct 21, 2024
Merged

Feat/3780/buildings without area #3789

merged 16 commits into from
Oct 21, 2024

Conversation

polina-schoenfeld-mw
Copy link
Collaborator

Show buildings with no area metric

Closes: #3780

Description

  • Buildings are shown, that have an area metric value of 0

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

lisa.walter and others added 16 commits October 9, 2024 15:52
chore(visualization): add example file
c59e2fe
@polina-schoenfeld-mw
Merge remote-tracking branch 'refs/remotes/origin/main' into feat/378…
11d336d 
…0/buildings-without-area
@polina-schoenfeld-mw
Merge remote-tracking branch 'refs/remotes/origin/main' into feat/378…
a41520b 
…0/buildings-without-area
@polina-schoenfeld-mw
feat(github): set minimum value to 0.5 and update sortNodes method
427d952
@polina-schoenfeld-mw
feat(visualization): define and set min node length
8b458be
@polina-schoenfeld-mw
chore(visualization): update test file
3997076
@polina-schoenfeld-mw
feat(visualization): hide functionality behind experimentalFeaturesEn…
3179690 
…abled flag
@polina-schoenfeld-mw
chore(visualization): update changelog
313bc9d
@polina-schoenfeld-mw
Merge remote-tracking branch 'origin/main' into feat/3780/buildings-w…
be472f3 
…ithout-area

# Conflicts:
#	visualization/CHANGELOG.md
@polina-schoenfeld-mw
refactor(visualization): use for..of instead of map
4aad29e
@polina-schoenfeld-mw
test(visualization): add tests for sortNodes method
cdda040
@polina-schoenfeld-mw
test(visualization): fix test
975149f
@polina-schoenfeld-mw
test(visualization): fix test
dee151c
@polina-schoenfeld-mw
Merge branch 'main' into feat/3780/buildings-without-area
2225b3b
@polina-schoenfeld-mw
feat(visualization): add tooltip
fa52032
@polina-schoenfeld-mw
Merge branch 'main' into feat/3780/buildings-without-area
9d6c6fe
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 21, 2024

Quality Gate Passed Quality Gate passed for 'CodeCharta Visualization'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 21, 2024

Quality Gate Passed Quality Gate passed for 'CodeCharta Analysis'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@phanlezz phanlezz merged commit e8315b6 into main Oct 21, 2024
7 checks passed
@phanlezz phanlezz deleted the feat/3780/buildings-without-area branch October 21, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phanlezz phanlezz phanlezz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Buildings without area metrics should be visible
2 participants
@polina-schoenfeld-mw @phanlezz