Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech/3716/enable view encapsulation in ribbon bar #3779

Merged
merged 22 commits into from
Oct 9, 2024

Conversation

polina-schoenfeld-mw
Copy link
Collaborator

Enable View Encapsulation for RibbonBar Components

Closes: #3716

Description

  • Enable View Encapsulation for RibbonBar Components
  • Fix styling issues

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

lisa.walter and others added 19 commits October 8, 2024 14:28
@LisaWalter90 LisaWalter90 enabled auto-merge (squash) October 9, 2024 11:22
Copy link

sonarcloud bot commented Oct 9, 2024

Copy link

sonarcloud bot commented Oct 9, 2024

@LisaWalter90 LisaWalter90 merged commit 24d1ce4 into main Oct 9, 2024
7 checks passed
@LisaWalter90 LisaWalter90 deleted the tech/3716/enable-view-encapsulation-in-ribbon-bar branch October 9, 2024 12:19
ViktoriaGordeevaVG added a commit that referenced this pull request Oct 10, 2024
* add restriction to how much the user can rotate the map #3730

* update Three.js to the latest version #3730

* Limit rotation of camera and refactor viewcube accordingly

* Adjust wrong camera rotations and update tests #3730

* Fix failing font tests #3730

* Remove spaces to hopefully make linter happy #3730

* add tests for the viewCube meshGenerator #3735

* Feat/3771/comparison of incompatible maps (#3773)

* feat(visualization): open incompatibleMapsDialog in filePanelDeltaSelector if necessary

* feat(visualization): open incompatibleMapsDialog with the correct data and show file with the mcc metric

* feat(visualization): add checkbox to disable alert

* feat(visualization): add and improve styling

* feat(visualization): add styling

* test(visualization): delete e2e test

* test(visualization): add tests

* chore(visualization): formatting

* chore(visualization): update changelog

* refactor(visualization): add data mock and rename old one

* test(visualization): add tests for FilePanelDeltaSelectorComponent

---------

Co-authored-by: lisa.walter <[email protected]>

* Feature/3745/structure incompatible file merge (#3774)

* #3745 add a pre-check  before merging (non-)overlapping already specified modules

* #3745 expand the pre-check merge process for non-overlapping modules in the ParserDialog

* #3745 add Unit Tests

* #3745 add Changelog.md

* #3745 fix kotlin style violations

* #3745 fix kotlin style violations

* #3745 add Test to warn about invalid project files

* #3745 add Unit Tests

* #3745 wip

* #3745 fix the invalidInput exception

* #3745 remove comments in MergeFilterTest

---------

Co-authored-by: VictoriaG <[email protected]>

* Tech/3716/enable view encapsulation in ribbon bar (#3779)

* feat(visualization): enable view encapsulation in show scenarios button

* feat(visualization): enable view encapsulation in scenarios menu

* feat(visualization): enable view encapsulation in thumbTackButton and sortingButton

* feat(visualization): enable View Encapsulation for sortingOption

* feat(visualization): enable View Encapsulation for MatchingFilesCounterComponent

* fix(visualization): import styling

* feat(visualization): enable View Encapsulation for SearchPanelModeSelectorComponent

* feat(visualization): enable View Encapsulation for SearchBar

* feat(visualization): enable View Encapsulation for blacklistPanel

* feat(visualization): enable View Encapsulation for LinkColorMetricToHeightMetricButtonComponent

* feat(visualization): enable view encapsulation in settings panels

* feat(visualization): enable view encapsulation in suspicious metrics dialog

* feat(visualization): enable View Encapsulation for range slider

* feat(visualization): enable View Encapsulation for edgeMetricToggle

* feat(visualization): enable View Encapsulation for highRiskProfile

* feat(visualization): enable View Encapsulation for suspiciousMetrics

* refactor(visualization): add css file for suspiciousMetricsList

* feat(visualization): enable ViewEncapsulation for artificialIntelligence

* chore(visualization): update changelog

---------

Co-authored-by: lisa.walter <[email protected]>
Co-authored-by: Lisa Walter <[email protected]>

* resolve merge conflict

* update Three.js to the latest version #3730

* Limit rotation of camera and refactor viewcube accordingly

* Adjust wrong camera rotations and update tests #3730

* Fix failing font tests #3730

* add tests for the viewCube meshGenerator #3735

---------

Co-authored-by: nereboss <[email protected]>
Co-authored-by: Niklas Kneißl <[email protected]>
Co-authored-by: polina-schoenfeld-mw <[email protected]>
Co-authored-by: lisa.walter <[email protected]>
Co-authored-by: ViktoriaGordeevaVG <[email protected]>
Co-authored-by: VictoriaG <[email protected]>
Co-authored-by: Lisa Walter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable view encapsulation for components inside Ribbon Bar
2 participants