Fix/3137/Floor Labels Are Disappearing #3778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phanlezz
force-pushed
the
fix/3137/floor-labels-are-disappearing
branch
from
4cb4bcd
to
4ca5bbd
Compare
|
For the review: |
|
I'm not sure what the problem is with the e2e tests. Must be a GitHub/Chrome thing? I will look tomorrow into this. |
phanlezz
force-pushed
the
fix/3137/floor-labels-are-disappearing
branch
from
97d58b7
to
5989c13
Compare
ViktoriaGordeevaVG
approved these changes
Oct 16, 2024
…map to reduce flickering
…lt folder height (to avoid that label fly way to high above the folders), slightly increase multiplicator for folder heights
phanlezz
force-pushed
the
fix/3137/floor-labels-are-disappearing
branch
from
5989c13
to
bbc2785
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Floor Labels Are Disappearing
Closes: #3137
Description
This adds a experimental feature to the FloorLabel system. When experimental features are enabled, the height of the floor labels gets scaled with the size of the map to increase the distance between folder structures and the floating labels above. In testing, this change result in less flickering of those labels. "Less", because the flickering is not completely removed. We might be able to remove the flickering completely by swapping to native three.js text instead of our current approach.
Definition of Done
A PR is only ready for merge once all the following acceptance criteria are fulfilled:
Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)Screenshots or gifs