Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/3767/legend panel #3770

Merged
merged 12 commits into from
Sep 26, 2024
Merged

Fix/3767/legend panel #3770

merged 12 commits into from
Sep 26, 2024

Conversation

polina-schoenfeld-mw
Copy link
Collaborator

@polina-schoenfeld-mw polina-schoenfeld-mw commented Sep 26, 2024 •
edited
Loading

Legend Panel closes on outside click

Closes: #3767

Description

  • Legend Panel closes on outside click

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

lisa.walter and others added 12 commits September 24, 2024 15:30
fix(visualization): close legend panel on outside click
c4180f9
begin test(visualization): test closing on outside clicks for legend …
3b1c92a 
…panel
@polina-schoenfeld-mw
chore(visualization): update changelog
1a1f043
@polina-schoenfeld-mw
Merge remote-tracking branch 'refs/remotes/origin/main' into fix/3767…
0def52e 
…/legend-panel
@polina-schoenfeld-mw
chore(visualization): update changelog
2cea490
@polina-schoenfeld-mw
test(visualization): only call render once for instantiating the test…
50f2c9f 
…s and improve tests
test(visualization): add test for click on pop up and switch to userE…
10a9601 
…vents
@polina-schoenfeld-mw
chore(visualization): formatting and rearranging
4ebc86b
@polina-schoenfeld-mw
test(visualization): formatting and fixing tests
e47c1cc
@polina-schoenfeld-mw
chore(visualization):update changelog
7c1b434
@polina-schoenfeld-mw
Merge branch 'main' into fix/3767/legend-panel
63f05b6
@polina-schoenfeld-mw
test(visualization):fix tests and open legend panel after elements we…
44fa0eb 
…re clicked
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 26, 2024

Quality Gate Passed Quality Gate passed for 'CodeCharta Visualization'

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
95.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 26, 2024

Quality Gate Passed Quality Gate passed for 'CodeCharta Analysis'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@polina-schoenfeld-mw polina-schoenfeld-mw merged commit c089981 into main Sep 26, 2024
7 checks passed
@polina-schoenfeld-mw polina-schoenfeld-mw deleted the fix/3767/legend-panel branch September 26, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LisaWalter90 LisaWalter90 LisaWalter90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Legend Panel does not close on outside Click
2 participants
@polina-schoenfeld-mw @LisaWalter90