Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech/3727/view encapsulation buttons #3729

Merged
merged 8 commits into from
Sep 10, 2024
Merged

Tech/3727/view encapsulation buttons #3729

merged 8 commits into from
Sep 10, 2024

Conversation

polina-schoenfeld-mw
Copy link
Collaborator

Enable View Encapsulation for buttons

Issue: #3727

Description

  • Enable View Encapsulation for Buttons and the corresponding components

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

lisa.walter and others added 8 commits September 9, 2024 15:10
fix(visualization): enable view encapsulation in centerMapButton and …
6d217f1 
…fix hover background color
chore(visualization): enable view encapsulation in vieCube and move s…
3a4ec63 
…tyling
chore(visualization): enable view encapsulation in nodeContextMenuCar…
1d09120 
…d and buttons and move styling
chore(visualization): enable view encapsulation in addCustomConfigButton
1b0feb6
@polina-schoenfeld-mw
chore(visualization): enable view encapsulation for applyCustomConfig…
2d4a53f 
…Button
@polina-schoenfeld-mw
chore(visualization): enable view encapsulation for custom configs an…
8f47c63 
…d move styling
@polina-schoenfeld-mw
chore(visualization): enable view encapsulation for reset settings bu…
1626821 
…tton
chore(visualization): remove unnecessary host selector in centerMapBu…
83f21c4 
…tton.component.scss
@LisaWalter90 LisaWalter90 enabled auto-merge (squash) September 10, 2024 12:09
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 10, 2024

Quality Gate Passed Quality Gate passed for 'CodeCharta Visualization'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 10, 2024

Quality Gate Passed Quality Gate passed for 'CodeCharta Analysis'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@LisaWalter90 LisaWalter90 merged commit ae21860 into main Sep 10, 2024
7 checks passed
@LisaWalter90 LisaWalter90 deleted the tech/3727/view-encapsulation-buttons branch September 10, 2024 12:20
@phanlezz phanlezz mentioned this pull request Sep 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LisaWalter90 LisaWalter90 LisaWalter90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@polina-schoenfeld-mw @LisaWalter90