Fix/3478/reset camera global option broken #3699
Conversation
IdrisLaabidi
force-pushed
the
fix/3478/reset-camera-global-option-broken
branch
from
829aa7e
to
b0229c6
Compare
This reverts commit 95c7ecb.
…github.com/MaibornWolff/codecharta into fix/3478/reset-camera-global-option-broken
visualization/CHANGELOG.md
Outdated
| @@ -15,6 +15,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/) | |||
| ### Fixed 🐞 | |||
|
|
|||
| - Fix issue where zooming out too much makes the map disappear and zooming in too much causes you to go through the map. [#3697](https://github.com/MaibornWolff/codecharta/pull/3697) | |||
| - Camera perspective is correctly adopted from the custom configuration[#3194](https://github.com/MaibornWolff/codecharta/pull/3194) | |||
There was a problem hiding this comment.
Not so sure why, but this redirects to an issue. According to our guidelines it should be a PR, preferably this one.
| @@ -29,7 +31,6 @@ and this project adheres to [Semantic Versioning](http://semver.org/) | |||
| ### Fixed 🐞 | |||
|
|
|||
| - Revert [#3655](https://github.com/MaibornWolff/codecharta/pull/3665) as we implement new navigation methods | |||
| - Camera perspective is correctly adopted from the custom configuration[#3194](https://github.com/MaibornWolff/codecharta/pull/3194) | |||
There was a problem hiding this comment.
Why do we need to change the changelog of previous versions?
There was a problem hiding this comment.
Actually, that's a recent bug fix, it has nothing to do with the previous version. It was there by mistake, and I corrected it
| await wait(0) | ||
|
|
||
| expect(threeCameraService.camera.position).toEqual(new Vector3(0, 0, 0)) | ||
| //expect(threeRendererService.render).not.toHaveBeenCalled() |
There was a problem hiding this comment.
remove commented line if not being used
|
|
Fix camera breaking because of the global option 'reset camera when changing map'
Issue: #3478
Description
Definition of Done
A PR is only ready for merge once all the following acceptance criteria are fulfilled:
Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)Screenshots or gifs