Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/3194/camera perspective of custom view #3698

Merged
merged 4 commits into from
Aug 23, 2024

Conversation

ViktoriaGordeevaVG
Copy link
Collaborator

Loading a custom config is considered as changing map

Issue: #3194

Description

The camera should switch to the custom view when a custom configuration is loaded. Previously, the camera perspective from the custom configuration was being ignored and not applied correctly. This issue has been resolved, and now the camera perspective is correctly adopted from the custom configuration.

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

Copy link

sonarcloud bot commented Aug 22, 2024

Copy link

sonarcloud bot commented Aug 22, 2024

Copy link
Contributor

@IdrisLaabidi IdrisLaabidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!💯

@ViktoriaGordeevaVG ViktoriaGordeevaVG merged commit 4ae17da into main Aug 23, 2024
7 checks passed
@ViktoriaGordeevaVG ViktoriaGordeevaVG deleted the bug/3194/camera-perspective-of-custom-view branch August 23, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants