-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/3682/map navigation improvement #3693
Merged
Merged
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
3f07dff
update three.js to version 156
IdrisLaabidi 638139d
fixed deprecated imports in some test files
IdrisLaabidi 6f6fe74
get latest updates from main
IdrisLaabidi 2894bad
readjusted light intensity
IdrisLaabidi 4bd4805
updated package-lock.json
IdrisLaabidi 82ff67e
updated snapshots
IdrisLaabidi f2ed6ef
additional test fixes
IdrisLaabidi a3bee37
renaming every instance of threeOrbitControls to threeMapControls
IdrisLaabidi e2b1f85
#3682: Modify test file so that it does not contain any more TextGeom…
phanlezz 2e28169
add a changelog entry #3682
IdrisLaabidi 4c5ca3e
Merge branch 'main' into feature/3682/map-navigation-improvement
IdrisLaabidi bc26171
update changelog entry #3682
IdrisLaabidi 3888660
Merge branch 'main' into feature/3682/map-navigation-improvement
IdrisLaabidi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14,106 changes: 1,121 additions & 12,985 deletions
14,106
visualization/app/codeCharta/resources/minimalScene.json
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be removed imo, usually dependency updates are not included in the changelog. Only core packages, like node, that require user attention, are stated. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can add in the "fixed" section, that the configuration "reset camera when changing map" now works as intended💯 seems like this issue was only happening locally for me sometimes