Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech: Enable metric-gardener inside analysis and docker #3691

Conversation

phanlezz
Copy link
Collaborator

@phanlezz phanlezz commented Aug 13, 2024

Tech: Re-Add metric-gardener to the analysis project and its docker container

Closes: #3547

Description

  • Enable metric-gardener on-the-fly execution in analysis
  • Add metric-gardener installation to the analysis Dockerfile
  • Upgrade node to version 20 inside the analysis Dockerfile

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

@phanlezz phanlezz self-assigned this Aug 13, 2024
@phanlezz phanlezz marked this pull request as ready for review August 14, 2024 07:58
@phanlezz phanlezz force-pushed the tech/3547/re-activate-metricgardener-on-the-fly-exec-and-inside-docker branch from 0a3da63 to 1fb7037 Compare August 14, 2024 08:16
Copy link

sonarcloud bot commented Aug 14, 2024

Copy link

sonarcloud bot commented Aug 14, 2024

Copy link
Contributor

@Nereboss Nereboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@phanlezz phanlezz merged commit 4a09858 into main Aug 14, 2024
7 checks passed
@phanlezz phanlezz deleted the tech/3547/re-activate-metricgardener-on-the-fly-exec-and-inside-docker branch August 14, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-Activate Metric-Gardener after a new release metricgardener and Node20 Upgrade
2 participants