Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor map zoom function to use Three.js #3147 #3665

Merged
merged 11 commits into from
Jul 30, 2024

Conversation

IdrisLaabidi
Copy link
Contributor

@IdrisLaabidi IdrisLaabidi commented Jul 23, 2024

passing zoom function from OrbitControl to the camera

Issue: #3147

Description

  • Disable orbitControls zoom.Camera no longer moves when scrolling the mouse wheel.
  • Scrolling updates the zoom property of the PerspectiveCamera.
  • Introducing a Max and Min zoom factor to make sure that the map doesn't disappear if you zoom out .

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

Screenshots or gifs

@IdrisLaabidi IdrisLaabidi added bug Only issues that describe bugs. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. tech For technical stories without user impact (=refactoring stories). priority:high Set by PO labels Jul 24, 2024
Copy link
Collaborator

@IhsenBouallegue IhsenBouallegue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove the comments and make sure no memory leaks happen (because of the subscribe) otherwise LGTM 💯

Copy link

sonarcloud bot commented Jul 30, 2024

Copy link

sonarcloud bot commented Jul 30, 2024

@IdrisLaabidi IdrisLaabidi merged commit 89bd8bb into main Jul 30, 2024
7 checks passed
@IdrisLaabidi IdrisLaabidi deleted the fix/3147/refactor-zoom branch July 30, 2024 13:49
phanlezz added a commit that referenced this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Only issues that describe bugs. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:high Set by PO tech For technical stories without user impact (=refactoring stories).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants