Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(visualization/#3648): Make name of metric templates/scenarios consistent #3656

Merged

Conversation

alexanderroidl
Copy link
Contributor

@alexanderroidl alexanderroidl commented Jun 27, 2024

Make name of metric templates/scenarios consistent

Issue: #3648

Description

Descriptive pull request text, answering:

  • What problem/issue are you fixing?
  • What does this PR implement and how?

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

Screenshots or GIFs

Screenshot 2024-06-27 at 15 08 03

@alexanderroidl alexanderroidl linked an issue Jun 27, 2024 that may be closed by this pull request
@alexanderroidl alexanderroidl changed the title feat: Make name of metric templates/scenarios consistent feat(visualization/#3648): Make name of metric templates/scenarios consistent Jun 27, 2024
Copy link

sonarcloud bot commented Jun 27, 2024

Copy link

sonarcloud bot commented Jun 27, 2024

…8/metric-scenarios-naming-consistency

# Conflicts:
#	visualization/app/codeCharta/ui/ribbonBar/ribbonBar.component.html
@polina-schoenfeld-mw polina-schoenfeld-mw marked this pull request as ready for review September 24, 2024 12:54
Copy link

sonarcloud bot commented Sep 24, 2024

Copy link

sonarcloud bot commented Sep 24, 2024

@polina-schoenfeld-mw polina-schoenfeld-mw merged commit e36277f into main Sep 25, 2024
7 checks passed
@polina-schoenfeld-mw polina-schoenfeld-mw deleted the feat/3648/metric-scenarios-naming-consistency branch September 25, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make name of metric templates/scenarios consistent
2 participants