-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/3157/remove-download-button #3398
Conversation
One acceptance criteria was that the changelog informs about this "breaking" change. Did this happen in a sufficient manner or does the changelog need to be adjusted? |
@@ -15,7 +15,7 @@ The controls that are available to you are: | |||
| # | Type | Action | | |||
| --- | --------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | |||
| 1 | Settings | Load cc.json map or multiple maps (_hold shift_). | | |||
| 2 | Settings | Download the current map as a JSON-file. **Deprecation Warning!** This feature will soon be removed. It is already replaced by the controls nr. 15 and 16. | | |||
| 2 | Settings | **Removed!** This button no longer exists and has been replaced by the controls Nr. 15 and 16. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove this line completely :-)
| 2 | Settings | **Removed!** This button no longer exists and has been replaced by the controls Nr. 15 and 16. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I see that there is a gap then. So it is fine for me to keep it until we update the screenshot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :-)
Remove both the files and the calls of the toolbar
c535833
to
2bbd47e
Compare
[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed! |
[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed! |
Remove depricated download button
Closes: #3157
Description
Removes the download button from the UI and all corresponding files that are no longer necessary.