Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/3157/remove-download-button #3398

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

Nereboss
Copy link
Contributor

@Nereboss Nereboss commented Nov 7, 2023

Remove depricated download button

Closes: #3157

Description

Removes the download button from the UI and all corresponding files that are no longer necessary.

@Nereboss
Copy link
Contributor Author

Nereboss commented Nov 7, 2023

One acceptance criteria was that the changelog informs about this "breaking" change. Did this happen in a sufficient manner or does the changelog need to be adjusted?

@@ -15,7 +15,7 @@ The controls that are available to you are:
| # | Type | Action |
| --- | --------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| 1 | Settings | Load cc.json map or multiple maps (_hold shift_). |
| 2 | Settings | Download the current map as a JSON-file. **Deprecation Warning!** This feature will soon be removed. It is already replaced by the controls nr. 15 and 16. |
| 2 | Settings | **Removed!** This button no longer exists and has been replaced by the controls Nr. 15 and 16. |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this line completely :-)

Suggested change
| 2 | Settings | **Removed!** This button no longer exists and has been replaced by the controls Nr. 15 and 16. |

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I see that there is a gap then. So it is fine for me to keep it until we update the screenshot.

Copy link
Collaborator

@ce-bo ce-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

Remove both the files and the calls of the toolbar
@Nereboss Nereboss force-pushed the feature/3157/remove-download-button branch from c535833 to 2bbd47e Compare November 8, 2023 10:02
Copy link

sonarcloud bot commented Nov 8, 2023

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

sonarcloud bot commented Nov 8, 2023

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Nereboss Nereboss merged commit f7cf39d into main Nov 8, 2023
7 checks passed
@Nereboss Nereboss deleted the feature/3157/remove-download-button branch November 8, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Download button in Q2 2023
2 participants