Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup SonarCloud Scan Enviroment to use Java 17+ #3359

Merged
merged 37 commits into from
Sep 20, 2023
Merged

Setup SonarCloud Scan Enviroment to use Java 17+ #3359

merged 37 commits into from
Sep 20, 2023

Conversation

phanlezz
Copy link
Collaborator

Setup SonarCloud Scan Enviroment to use Java 17+

The linked docs state, that there should be no need for additional setup while using the github action. We might need to update the github action, as it wasn't updated in a while.

Additionally, the docs state, that we should not use the github action and use the gradle plugin instead.

Issue: #3357

@phanlezz phanlezz closed this Sep 7, 2023
@phanlezz phanlezz reopened this Sep 7, 2023
@phanlezz
Copy link
Collaborator Author

phanlezz commented Sep 7, 2023 •
edited
Loading

Gradle Sonarqube doesn't work with Java 8, so I will switch back to the github action to decouple the version requirements.

The github action requires the use of the gradle action since version 1.7. -> We must use the gradle version.

@phanlezz phanlezz self-assigned this Sep 7, 2023
ce-bo
ce-bo reviewed Sep 15, 2023
View reviewed changes
analysis/build.gradle Outdated Show resolved Hide resolved
ce-bo
ce-bo reviewed Sep 15, 2023
View reviewed changes
analysis/gradle.properties Outdated Show resolved Hide resolved
ce-bo
ce-bo reviewed Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@ce-bo ce-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM. We should discuss what kind of version update we wanna have due to the Java 11 Upgrade.

@phanlezz
Copy link
Collaborator Author

In general LGTM. We should discuss what kind of version update we wanna have due to the Java 11 Upgrade.

For the next release? Minor version would be fitting.

@phanlezz phanlezz marked this pull request as ready for review September 20, 2023 09:18
@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2023

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2023

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phanlezz phanlezz merged commit e5d9eba into main Sep 20, 2023
7 checks passed
@phanlezz phanlezz deleted the fix/3357/sonarcloud-java-version branch September 20, 2023 09:38
@phanlezz phanlezz mentioned this pull request Sep 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ce-bo ce-bo ce-bo approved these changes

Assignees

@phanlezz phanlezz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phanlezz @ce-bo