Fix ccsh cli problems by providings custom bin-links for the gradle executables #2600 #3354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for the executables #2600
ce-bo
reviewed
Aug 2, 2023
BridgeAR
reviewed
Aug 2, 2023
BridgeAR
reviewed
Aug 2, 2023
remove is-windows package for check
|
[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!
|
|
[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide custom bin-links for gradle executables
Closes #2600
Description
This PR provides a set of two bin-links scripts. Each sets contains three scripts (bin-links) that then call the correct bin script to execute ccsh. There are two ccsh-scripts produced by gradle, one for unix and one for windows, that need to be callled / linked in different ways.
Npm generates three links to those gradle scripts on package install. Sadly, npm does not provide any native method to change the behavior of those scripts, so this PR introduces custom scripts / bin-links. Those scripts are modified versions of the generated links.
Via a postinstall lifecycle call the modified links get copied to the npm directory. The location varies for a local or a global install.
The original issue was probably caused by broken java paths, because either the environment expected windows paths (
\) and got unix versions (/) or vice-versa.This fix enables direct and native execution of those gradle scripts, without any node calls or nested executions.