Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/3298/output-error-for-nonexistent-file-params #3305

Merged
merged 5 commits into from
May 19, 2023
Merged

fix/3298/output-error-for-nonexistent-file-params #3305

merged 5 commits into from
May 19, 2023

Conversation

moritz-suckow-mw
Copy link
Collaborator

@moritz-suckow-mw moritz-suckow-mw commented May 16, 2023 •
edited
Loading

Output error for each nonexistent file specified

Issue: #3298

Description

This PR adds an error message which is always output for each specified file parameter which is nonexistent.
In this PR this will only be implemented for the MergeFilter, all other parsers/filters will be added in another PR with the issue #3307
Edit: We will abort execution if one or more of the specified files is invalid.

@moritz-suckow-mw moritz-suckow-mw linked an issue May 16, 2023 that may be closed by this pull request
MergeFilter gives no hint if selected input does not exist #3298
Closed
@moritz-suckow-mw
Copy link
Collaborator Author

This basically does very similar things compared to the new #3307, but only for the MergeFilter. Therefore to not create additional refactoring work I tried to implement this here, like I would have done in #3307, so this is basically implementing #3307 for the MergeFilter.

ce-bo
ce-bo approved these changes May 19, 2023
View reviewed changes
Copy link
Collaborator

@ce-bo ce-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's add a changelog entry.

@phanlezz phanlezz enabled auto-merge (squash) May 19, 2023 07:59
phanlezz
phanlezz approved these changes May 19, 2023
View reviewed changes
Copy link
Collaborator

@phanlezz phanlezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@sonarcloud
Copy link

sonarcloud bot commented May 19, 2023

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

97.3% 97.3% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented May 19, 2023

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phanlezz phanlezz merged commit 118ab61 into main May 19, 2023
@phanlezz phanlezz deleted the fix/3298/output-error-for-nonexistent-file-params branch May 19, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phanlezz phanlezz phanlezz approved these changes

@ce-bo ce-bo ce-bo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MergeFilter gives no hint if selected input does not exist
3 participants
@moritz-suckow-mw @ce-bo @phanlezz