Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/3288/Adjust logos #3302

Merged
merged 3 commits into from
May 16, 2023
Merged

Feature/3288/Adjust logos #3302

merged 3 commits into from
May 16, 2023

Conversation

Hall-Ma
Copy link
Contributor

@Hall-Ma Hall-Ma commented May 15, 2023

Refactors Logo(s)

Closes: #3288

Description

  • removed MaibornWolff logo
  • CC logo and version text made smaller and placed more in the corner

Screenshots or gifs

Same screen size!
Before:
image

After:
image

@Hall-Ma Hall-Ma requested a review from ce-bo May 15, 2023 16:02
@Hall-Ma
Copy link
Contributor Author

Hall-Ma commented May 15, 2023

@ce-bo I think this size should be okay for every screen size. For example, when I open CC on my smartphone (not recommended), the logo is already resized. Give it a try 😃

@ce-bo ce-bo force-pushed the feature/3288/adjust-logos branch from 09332fe to f176a6f Compare May 16, 2023 09:26
Copy link
Collaborator

@ce-bo ce-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-) Thank you @Hall-Ma

@sonarqubecloud
Copy link

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Hall-Ma Hall-Ma enabled auto-merge (squash) May 16, 2023 09:35
@sonarqubecloud
Copy link

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Hall-Ma Hall-Ma merged commit 020fcc4 into main May 16, 2023
@Hall-Ma Hall-Ma deleted the feature/3288/adjust-logos branch May 16, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logo is significantly too big
2 participants