Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/3261/Changelog Dialog #3264

Merged
merged 10 commits into from
Apr 5, 2023
Merged

Fix/3261/Changelog Dialog #3264

merged 10 commits into from
Apr 5, 2023

Conversation

Hall-Ma
Copy link
Contributor

@Hall-Ma Hall-Ma commented Mar 31, 2023

Fix disappearance of changelog entries in dialog

Close: #3261, #3266

Description

  • ensures that new lines are recognized when the change log is read in and that a new array entry is added per line.
  • to ensure that the changelog dialogue renders content, an e2e test was created

@Hall-Ma Hall-Ma requested a review from ce-bo April 3, 2023 18:36
visualization/package.json Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Apr 5, 2023

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Hall-Ma Hall-Ma enabled auto-merge (squash) April 5, 2023 15:37
@sonarcloud
Copy link

sonarcloud bot commented Apr 5, 2023

[CodeCharta Visualization] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

63.6% 63.6% Coverage
0.0% 0.0% Duplication

@Hall-Ma Hall-Ma disabled auto-merge April 5, 2023 15:46
@Hall-Ma Hall-Ma merged commit e1de83b into main Apr 5, 2023
@Hall-Ma Hall-Ma deleted the fix/3261/changelog-dialog branch April 5, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changelog is empty in visualization popup
3 participants