Skip to content

Release/v2.11.6 httpproxy #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
acormier-maia wants to merge 3 commits into from
Closed

Release/v2.11.6 httpproxy #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
02af92d
Implements HTTP proxy support for WebSocket leafnode connections, ena…
Sep 10, 2025
bf838af
fix: Do not enforce websocket restriction on proxy
acormier-maia Sep 11, 2025
683a552
fix: Add version tag
acormier-maia Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
337 changes: 337 additions & 0 deletions server/config_check_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2153,6 +2153,343 @@ func TestConfigCheck(t *testing.T) {
errorLine: 3,
errorPos: 5,
},
{
name: "Proxies wrong type",
config: `
port: -1
proxies: 123
`,
err: errors.New("expected proxies to be a map/struct, got int64"),
errorLine: 3,
errorPos: 5,
},
{
name: "Proxies unknown field",
config: `
port: -1
proxies: {
field1: 123
}
`,
err: errors.New("unknown field"),
errorLine: 4,
errorPos: 6,
},
{
name: "Proxies trusted wrong type",
config: `
port: -1
proxies: {
trusted: 123
}
`,
err: errors.New("expected proxies' trusted field to be an array, got int64"),
errorLine: 4,
errorPos: 6,
},
{
name: "Proxies trusted key wrong type",
config: `
port: -1
proxies: {
trusted: [
"abc",
"def"
]
}
`,
err: errors.New("expected proxies' trusted entry to be a map/struct, got string"),
errorLine: 5,
errorPos: 8,
},
{
name: "Proxies trusted unknown field",
config: `
port: -1
proxies: {
trusted: [
{
key: "UCARKS2E3KVB7YORL2DG34XLT7PUCOL2SVM7YXV6ETHLW6Z46UUJ2VZ3"
field1: 123
}
]
}
`,
err: errors.New("unknown field"),
errorLine: 7,
errorPos: 8,
},
{
name: "Proxies trusted key invalid",
config: `
port: -1
proxies: {
trusted: [
{key: "UCARKS2E3KVB7YORL2DG34XLT7PUCOL2SVM7YXV6ETHLW6Z46UUJ2VZ3"}
{key: "bad1"}
{key: "UD6AYQSOIN2IN5OGC6VQZCR4H3UFMIOXSW6NNS6N53CLJA4PB56CEJJI"}
{key: "bad2"}
]
}
`,
err: errors.New("invalid proxy key"),
errorLine: 6,
errorPos: 8,
},
{
name: "Auth user require proxied wrong type",
config: `
port: -1
authorization {
user: user
password: pwd
proxy_required: 123
}
`,
err: errors.New("interface conversion"),
errorLine: 6,
errorPos: 6,
},
{
name: "Auth users require proxied wrong type",
config: `
port: -1
authorization {
users: [
{
user: user
password: pwd
proxy_required: 123
}
]
}
`,
err: errors.New("interface conversion"),
errorLine: 8,
errorPos: 8,
},
{
name: "Auth nkey users require proxied wrong type",
config: `
port: -1
authorization {
users: [
{
nkey: "UCARKS2E3KVB7YORL2DG34XLT7PUCOL2SVM7YXV6ETHLW6Z46UUJ2VZ3"
proxy_required: 123
}
]
}
`,
err: errors.New("interface conversion"),
errorLine: 7,
errorPos: 8,
},
{
name: "Account users require proxied wrong type",
config: `
port: -1
accounts {
A: {
users: [
{
user: user
password: pwd
proxy_required: 123
}
]
}
}
`,
err: errors.New("interface conversion"),
errorLine: 9,
errorPos: 9,
},
{
name: "Account nkey users require proxied wrong type",
config: `
port: -1
accounts {
A: {
users: [
{
nkey: "UCARKS2E3KVB7YORL2DG34XLT7PUCOL2SVM7YXV6ETHLW6Z46UUJ2VZ3"
proxy_required: 123
}
]
}
}
`,
err: errors.New("interface conversion"),
errorLine: 8,
errorPos: 9,
},
{
name: "Leafnode user require proxied wrong type",
config: `
port: -1
leafnodes {
port: -1
authorization {
user: user
password: pwd
proxy_required: 123
}
}
`,
err: errors.New("interface conversion"),
errorLine: 8,
errorPos: 7,
},
{
name: "Leafnode neky user require proxied wrong type",
config: `
port: -1
leafnodes {
port: -1
authorization {
nkey: "UCARKS2E3KVB7YORL2DG34XLT7PUCOL2SVM7YXV6ETHLW6Z46UUJ2VZ3"
proxy_required: 123
}
}
`,
err: errors.New("interface conversion"),
errorLine: 7,
errorPos: 7,
},
{
name: "Leafnode users require proxied wrong type",
config: `
port: -1
leafnodes {
port: -1
authorization {
users: [
{
user: user
password: pwd
proxy_required: 123
}
]
}
}
`,
err: errors.New("interface conversion"),
errorLine: 10,
errorPos: 9,
},
{
name: "Leafnode nkey users require proxied wrong type",
config: `
port: -1
leafnodes {
port: -1
authorization {
users: [
{
nkey: "UCARKS2E3KVB7YORL2DG34XLT7PUCOL2SVM7YXV6ETHLW6Z46UUJ2VZ3"
proxy_required: 123
}
]
}
}
`,
err: errors.New("interface conversion"),
errorLine: 9,
errorPos: 9,
},
{
name: "leafnode proxy with unsupported scheme",
config: `
leafnodes {
remotes = [
{
url: "nats://127.0.0.1:7422"
proxy {
url: "ftp://proxy.example.com:8080"
}
}
]
}
`,
err: errors.New("proxy URL scheme must be http or https, got: ftp"),
errorLine: 6,
errorPos: 8,
},
{
name: "leafnode proxy with missing host",
config: `
leafnodes {
remotes = [
{
url: "nats://127.0.0.1:7422"
proxy {
url: "http://"
}
}
]
}
`,
err: errors.New("proxy URL must specify a host"),
errorLine: 6,
errorPos: 8,
},
{
name: "leafnode proxy with username but no password",
config: `
leafnodes {
remotes = [
{
url: "nats://127.0.0.1:7422"
proxy {
url: "http://proxy.example.com:8080"
username: "testuser"
}
}
]
}
`,
err: errors.New("proxy username and password must both be specified or both be empty"),
errorLine: 6,
errorPos: 8,
},
{
name: "leafnode proxy with password but no username",
config: `
leafnodes {
remotes = [
{
url: "nats://127.0.0.1:7422"
proxy {
url: "http://proxy.example.com:8080"
password: "testpass"
}
}
]
}
`,
err: errors.New("proxy username and password must both be specified or both be empty"),
errorLine: 6,
errorPos: 8,
},
{
name: "leafnode proxy with WSS URL but no TLS config",
config: `
leafnodes {
remotes = [
{
url: "wss://127.0.0.1:7422"
proxy {
url: "http://proxy.example.com:8080"
}
}
]
}
`,
err: errors.New("proxy is configured but remote URL wss://127.0.0.1:7422 requires TLS and no TLS configuration is provided"),
errorLine: 6,
errorPos: 8,
},
}

checkConfig := func(config string) error {
Expand Down
2 changes: 1 addition & 1 deletion server/const.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ func init() {

const (
// VERSION is the current version for the server.
VERSION = "2.11.6"
VERSION = "2.11.6-httpproxy"

// PROTO is the currently supported protocol.
// 0 was the original
Expand Down
Loading
Loading