-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instance set by value does not appear in Kaitai Struct output #145
Comments
thanks for the heads up, I will look into this. |
I'm not sure how to get the appropriate information about test2 from the information that Kaitai provides. It isn't in the I noticed that the produced byte length is inaccurate in the example you gave, and I fixed that in fdc2b10 |
Instances set by value aren't going to be in the _debug dict, since they don't have a start or end because they are set directly, not in the stream. You could fix this by looping over all attributes of the object and not just the attributes in _debug. I wrote an example implementation of this method - jakecrowley/hobbits@1c49116 |
ok, cool, I might just steal that because I don't have a better idea. Feel free to do pull request into develop if you think it's a reasonable solution - as you have seen, the whole script is pretty hacky. |
It hasn't been tested very extensively, but it seems to work in my short testing. I've gone ahead and created a PR if you are okay with merging. |
fix KaitaiStruct value instances not appearing
## [0.53.2](Mahlet-Inc/hobbits@v0.53.1...v0.53.2) (2022-06-08) ### Bug Fixes * correctly display kaitai value instances for [#145](Mahlet-Inc/hobbits#145) ([556514b](Mahlet-Inc/hobbits@556514b)) * fix kaitai plugin byte and string array sizes ([fdc2b10](Mahlet-Inc/hobbits@fdc2b10))
## [0.53.2](Mahlet-Inc/hobbits@v0.53.1...v0.53.2) (2022-06-08) ### Bug Fixes * correctly display kaitai value instances for [Mahlet-Inc#145](Mahlet-Inc#145) ([556514b](Mahlet-Inc@556514b)) * fix kaitai plugin byte and string array sizes ([fdc2b10](Mahlet-Inc@fdc2b10))
In the Kaitai Struct plugin, if you have an instance set by a value, it fails to appear in the "Parsed" tab.
for example:
should result in something like this (from kaitai struct visualizer):
however, in Hobbits, it appears like this:
The text was updated successfully, but these errors were encountered: