-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Highlight Visual C++ Redistribution along side with download link #271
Comments
Does it mean if the check fails, users can also continue to use Neuron? Sometimes the check fails not cause by not installed but fails with the command. For example, #134 |
Yes, allow users to keep using Neuron even if the check fails. There are 2 exceptions making
For case 1, both For case 2, new users will be timely informed about the |
|
Visual C++ Redistributable is required by CKB node as mentioned at https://docs.nervos.org/docs/basics/guides/ckb-on-windows/#download-from-releases and Neuron doesn't synchronize if it's not installed.
To ensure the
vc_redist.x64.exe
has been installed before starting, Neuron checks the windows system registry at https://github.com/nervosnetwork/neuron/blob/develop/packages/neuron-wallet/src/utils/redist-check.ts#L12-L16.But the check does not 100% work, and users will be informed with an alert of https://github.com/nervosnetwork/neuron/blob/f7d28f2d1f5ad38581697cc621d35ca20073720e/packages/neuron-wallet/src/services/node.ts#L212. It's too technical for some users.
So I think a note of the
vc_redist.x64.exe
could be appended around the download link to inform users to install the dependencyThe text was updated successfully, but these errors were encountered: