Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight Visual C++ Redistribution along side with download link #271

Open
Keith-CY opened this issue Aug 24, 2023 · 5 comments
Open

Highlight Visual C++ Redistribution along side with download link #271

Keith-CY opened this issue Aug 24, 2023 · 5 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@Keith-CY
Copy link
Member

Visual C++ Redistributable is required by CKB node as mentioned at https://docs.nervos.org/docs/basics/guides/ckb-on-windows/#download-from-releases and Neuron doesn't synchronize if it's not installed.

To ensure the vc_redist.x64.exe has been installed before starting, Neuron checks the windows system registry at https://github.com/nervosnetwork/neuron/blob/develop/packages/neuron-wallet/src/utils/redist-check.ts#L12-L16.

But the check does not 100% work, and users will be informed with an alert of https://github.com/nervosnetwork/neuron/blob/f7d28f2d1f5ad38581697cc621d35ca20073720e/packages/neuron-wallet/src/services/node.ts#L212. It's too technical for some users.

So I think a note of the vc_redist.x64.exe could be appended around the download link to inform users to install the dependency

@Keith-CY Keith-CY added the documentation Improvements or additions to documentation label Aug 24, 2023
@yanguoyu
Copy link

Does it mean if the check fails, users can also continue to use Neuron? Sometimes the check fails not cause by not installed but fails with the command. For example, #134

@Keith-CY
Copy link
Member Author

Does it mean if the check fails, users can also continue to use Neuron? Sometimes the check fails not cause by not installed but fails with the command. For example, #134

Yes, allow users to keep using Neuron even if the check fails.

There are 2 exceptions making check not 100% work

  1. vc_redist is installed, but it's not detected, so the alert shows
  2. vc_redist is not installed, but it's mistakenly detected, so the alert doesn't show

For case 1, both install vc_redist and ignore it work because vc_redist is actually installed. But the solution(#134 (comment)) to fix detection can be appended in the note too.

For case 2, new users will be timely informed about the vc_redist on downloading Neuron once the note is added.

@Danie0918
Copy link
Contributor

Image

  • Requirement:
  1. Download Note added Visual C++ Redistributable tip.
  2. Highlight Visual C++ Redistributable and click to jump https://learn.microsoft.com/cpp/windows/latest-supported-vc-redist?view=msvc-170

@Kirl70
Copy link

Kirl70 commented Jul 12, 2024

@yanguoyu
Copy link

Magickbase/websites#124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: ✅ Done
Development

No branches or pull requests

5 participants