feat(inscription): new ui #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Daryl-L
force-pushed
the
feature/inscription
branch
from
1ee103c
to
0c05562
Compare
|
Please set the reviewers when the PR is ready, or we can mark it as a draft PR |
Keith-CY
approved these changes
Aug 23, 2024
src/pages/Address/AddressComp.tsx
Outdated
| switch (inscription.udtType) { | ||
| case 'omiga_inscription': | ||
| return ( | ||
| <AddressOmigaInscriptionComp |
There was a problem hiding this comment.
Address Component should be wrapped by <li></li> because it's in <ul></ul>
src/pages/Address/Inscription.tsx
Outdated
| udtLabel: string | ||
| }) => { | ||
| return ( | ||
| <a href={href} className={styles.container}> |
There was a problem hiding this comment.
Use Link component if it navigates internally.
|
UI： Corresponding screenshots:
|
Daryl-L
force-pushed
the
feature/inscription
branch
from
aa48fb1
to
0bd88ad
Compare
FrederLu
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Magickbase/ckb-explorer-public-issues#536
http://localhost:3000/address/ckt1qrfrwcdnvssswdwpn3s9v8fp87emat306ctjwsm3nmlkjg8qyza2cqgqq85apn2vnk482lxg8p3uk30r78srnc0aqvyssuun