Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nft-tags): add nft-tags #394

Merged
merged 26 commits into from
Jul 31, 2024
Merged

feat(nft-tags): add nft-tags #394

merged 26 commits into from
Jul 31, 2024

Conversation

Daryl-L
Copy link

@Daryl-L Daryl-L commented Jul 2, 2024

Magickbase/ckb-explorer-public-issues#647

https://ckb-explorer-frontend-in-magickbase-repo-git-d27caf-magickbase.vercel.app/nft-collections

Because of using the component MultiFilterButton defined in #378, so this branch is based on it.

image

image

image

image

image

image

Copy link

vercel bot commented Jul 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ckb-explorer-frontend-in-magickbase-repo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 7:11am

src/components/FilterSortContainer/index.tsx Outdated Show resolved Hide resolved
src/pages/NftCollections/List.tsx Outdated Show resolved Hide resolved
@Keith-CY
Copy link
Member

Keith-CY commented Jul 9, 2024

Any update on the conversations above?

@Daryl-L
Copy link
Author

Daryl-L commented Jul 10, 2024

Any update on the conversations above?

solved

src/components/FilterSortContainer/index.tsx Outdated Show resolved Hide resolved
src/pages/NftCollections/index.tsx Outdated Show resolved Hide resolved
@FrederLu
Copy link

FrederLu commented Jul 11, 2024

image image

1、In the screenshot, the three tags cannot filter data. Are they not needed in the NFT Collection? At the same time, I see that there is an RGB++ compatible tag on the page, but there is no option for filtering. cc @Sven-TBD


image

2、When there is no data, paging needs to be handled.


image image

3、After adding Tags to NFT Collection, the original Created Time and Creator styles became abnormal.


image

4、The font color in the label can be modified by referring to xudt.


image

5、The spacing between Tags and funnel icons can refer to Type's style, and the two should be consistent.


image

6、When clicking Tags on a mobile phone, you often mistakenly click on Holder/Minted. The Tags hot zone needs to be processed.

@Sven-TBD
Copy link

In the screenshot, the three tags cannot filter data. Are they not needed in the NFT Collection? At the same time, I see that there is an RGB++ compatible tag on the page, but there is no option for filtering.

The filter should align with the tag on the page @Daryl-L , The logic of NFT Tag filter should be the same as the XUDT, the difference is the tags themselves. cc @FrederLu

@Keith-CY Keith-CY merged commit f520137 into develop Jul 31, 2024
8 checks passed
@Keith-CY Keith-CY deleted the feature/nft-tag branch July 31, 2024 07:52
@FrederLu FrederLu restored the feature/nft-tag branch July 31, 2024 10:14
@FrederLu FrederLu deleted the feature/nft-tag branch July 31, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants