Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(asset): display multiple asset for RGB++ #384

Merged
merged 8 commits into from
Jun 28, 2024

Conversation

Copy link

vercel bot commented Jun 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ckb-explorer-frontend-in-magickbase-repo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 5:07pm

src/locales/en.json Outdated Show resolved Hide resolved
src/locales/zh.json Outdated Show resolved Hide resolved
@FrederLu
Copy link

FrederLu commented Jun 25, 2024

image

https://ckb-explorer-frontend-in-magickbase-repo-l26huxr04-magickbase.vercel.app/address/tb1qdj3cv8jktgvl4ey4h7v24xuthc8ta99gj4a6pf
image

1、In the UI, elements within a card should be left-aligned from top to bottom.


image image

2、Compared with UI, the quantity does not need to be displayed. At the same time, when the mouse is hovered over !, the mouse style needs to be processed and prompt information needs to be displayed.


image image

3、The style on the mobile terminal needs to be modified according to the UI.

Daryl-L and others added 2 commits June 25, 2024 16:10
Co-authored-by: Chen Yu <[email protected]>
Signed-off-by: daryl <[email protected]>
Co-authored-by: Chen Yu <[email protected]>
Signed-off-by: daryl <[email protected]>
@Daryl-L
Copy link
Author

Daryl-L commented Jun 27, 2024

@rabbitz
Copy link

rabbitz commented Jun 27, 2024

Request URL: https://ckb-explorer-api-staging.magickbase.com/api/v2/bitcoin_addresses/tb1qdj3cv8jktgvl4ey4h7v24xuthc8ta99gj4a6pf/rgb_cells?page=1&page_size=10&sort=capacity.desc
image API prompt 404.

Could you please have a check? @rabbitz

The code became invalid due to conflicts on staging, but the issue has been resolved.

@FrederLu
Copy link

Request URL: https://ckb-explorer-api-staging.magickbase.com/api/v2/bitcoin_addresses/tb1qdj3cv8jktgvl4ey4h7v24xuthc8ta99gj4a6pf/rgb_cells?page=1&page_size=10&sort=capacity.desc
image API prompt 404.

Could you please have a check? @rabbitz

The code became invalid due to conflicts on staging, but the issue has been resolved.

Now the interface is normal, but there is a problem with the page style. @Daryl-L
https://ckb-explorer-frontend-in-magickbase-repo-5y8xtqziq-magickbase.vercel.app/address/tb1qdj3cv8jktgvl4ey4h7v24xuthc8ta99gj4a6pf
image

@Daryl-L
Copy link
Author

Daryl-L commented Jun 27, 2024

Request URL: https://ckb-explorer-api-staging.magickbase.com/api/v2/bitcoin_addresses/tb1qdj3cv8jktgvl4ey4h7v24xuthc8ta99gj4a6pf/rgb_cells?page=1&page_size=10&sort=capacity.desc
image API prompt 404.

Could you please have a check? @rabbitz

The code became invalid due to conflicts on staging, but the issue has been resolved.

Should respond as object, not the string. @rabbitz
image

@rabbitz
Copy link

rabbitz commented Jun 28, 2024

Request URL: https://ckb-explorer-api-staging.magickbase.com/api/v2/bitcoin_addresses/tb1qdj3cv8jktgvl4ey4h7v24xuthc8ta99gj4a6pf/rgb_cells?page=1&page_size=10&sort=capacity.desc
image API prompt 404.

Could you please have a check? @rabbitz

The code became invalid due to conflicts on staging, but the issue has been resolved.

Should respond as object, not the string. @rabbitz image

It has been fixed.

@FrederLu
Copy link

https://ckb-explorer-api-staging.magickbase.com/api/v2/bitcoin_addresses/tb1qdj3cv8jktgvl4ey4h7v24xuthc8ta99gj4a6pf/rgb_cells?page=1&page_size=10&sort=capacity.desc
image
This interface request is not sorted, and the sorting information in the request can be removed.

@Daryl-L
Copy link
Author

Daryl-L commented Jun 28, 2024

/address/tb1qqlwxhg2jw392la2sesqqf4thjkz6q7nr4hcwwz

This rule was defined 3 months ago, I didn't change it.
image

@Keith-CY Keith-CY merged commit 6fcf5ed into develop Jun 28, 2024
8 checks passed
@Keith-CY Keith-CY deleted the feature/multi-rgb-assets branch June 28, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants