-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/l1 l2 #348
Feature/l1 l2 #348
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Internal Server Error from the API service. |
|
The reason of problem 1 is null returned from API |
@Sven-TBD Need to confirm here. |
Normally, this wont happen when this is a RGB++ Transaction. |
These issues remain to be addressed. |
Through the requirement on prd, the page does not display the label when null is returned. cc @Sven-TBD |
Through the requirement on prd, the page does not display the label when null is returned. cc @Sven-TBD The first condition shows if it was not a RGB++ transaction, but actually, it is. |
I just missed this comment, did you mean that we should not display the whole tag when it is null, even though it is a RGB++ transaction? |
Yes, we can do this first. |
@Daryl-L I found the API has been fixed by Nan, could you please fix this when you are free as well? "withinBTC" : " L1 -> L1" |
Co-authored-by: Chen Yu <[email protected]> Signed-off-by: daryl <[email protected]>
is null even though it is a RGB++ trasnaction
2024-06-13.12.06.29.movhttps://ckb-explorer-frontend-in-magickbase-repo-okomdwwgi-magickbase.vercel.app/transaction/0xd36d39eb0144a0135b21a2fdd5227b99bc6d2fc0d9d707c215e4e3fe1d585a52 The label on the side of |
I didn't get it from the draft, maybe it is not updated yet. Could you please make some confirmation? @Sven-TBD |
The design draft has been updated, and the labels are now aligned next to the |
The problem still exists. Data involving https://ckb-explorer-frontend-in-magickbase-repo-okomdwwgi-magickbase.vercel.app/transaction/0x9099747a27e3e4f5064c211a0192323b2268d26044a81369fff51df9e77666f3 "leap_direction": The data for "leapoutBTC" is missing RGB++ tags. |
added |
Magickbase/ckb-explorer-public-issues#656