Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/l1 l2 #348

Merged
merged 15 commits into from
Jun 19, 2024
Merged

Feature/l1 l2 #348

merged 15 commits into from
Jun 19, 2024

Conversation

Daryl-L
Copy link

@Daryl-L Daryl-L commented Jun 2, 2024

Copy link

vercel bot commented Jun 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ckb-explorer-frontend-in-magickbase-repo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2024 3:42am

src/components/Btc/Transaction/styles.module.scss Outdated Show resolved Hide resolved
src/locales/zh.json Outdated Show resolved Hide resolved
@Sven-TBD
Copy link

Sven-TBD commented Jun 3, 2024

The RGB++ list can not be loaded in this PR:
image

@Daryl-L

@Daryl-L
Copy link
Author

Daryl-L commented Jun 3, 2024

Visit Preview

Internal Server Error from the API service.

@FrederLu
Copy link

FrederLu commented Jun 4, 2024

https://ckb-explorer-frontend-in-magickbase-repo-1ten3dc96-magickbase.vercel.app/en/transaction/0x57872f2f13d1b0e583d66d5c2ee5b9ce10d775427eddcc988d413e6a873ec72f
image
image
image

image

1、Please follow the prd document for RGB++ attribute text. At the same time, the L1 ->L2 icon is missing next to RGB++ Digest.


image

2、The page is in Chinese, and the RGB++ attributes need to be translated into Chinese.


https://ckb-explorer-frontend-in-magickbase-repo-1ten3dc96-magickbase.vercel.app/transaction/0xa2f0e6e7a65ea7ab6623235f19c2a3dc0d5361d70e25df309fb65b2054c5ce9e
image
image

https://ckb-explorer-frontend-in-magickbase-repo-1ten3dc96-magickbase.vercel.app/address/tb1qd5q7hs0q0px6qj55j2nkkhjgm2zep7765zjyhs
image

3、The RGB++ attribute on the xudt list/Address shows unusual data.


image

4、Bitcoin TX: data is displayed repeatedly.


image

https://ckb-explorer-frontend-in-magickbase-repo-gcs17jfgu-magickbase.vercel.app/transaction/0x3068a4b4a57941ac41f120de3d831c8402f2a83800eebfe6dcba174e4850e1d0
image

https://ckb-explorer-frontend-in-magickbase-repo-gcs17jfgu-magickbase.vercel.app/address/ckt1qyq2c3mvt5m9rqpq4yw6y59w7h20g0vp8casg94j29
image

5、Data entered as btc time lock is missing attributes and L1->L2 icon.

  Corresponding relationship:   
  `["in", "isomorphic"]`  `L1->L2`;
  `["withinBTC", "isomorphic"]`   `L1->L1`
  `["in", "unlock"]`  `L1->L2`;

@Daryl-L
Copy link
Author

Daryl-L commented Jun 4, 2024

image
What should be displayed here when the transaction is neither isomorphic transaction or unlock transaction? @Sven-TBD

@Daryl-L
Copy link
Author

Daryl-L commented Jun 4, 2024

/transaction/0x57872f2f13d1b0e583d66d5c2ee5b9ce10d775427eddcc988d413e6a873ec72f

The reason of problem 1 is null returned from API

@FrederLu
Copy link

FrederLu commented Jun 5, 2024

/transaction/0x57872f2f13d1b0e583d66d5c2ee5b9ce10d775427eddcc988d413e6a873ec72f

The reason of problem 1 is null returned from API

@Sven-TBD Need to confirm here.

@Sven-TBD
Copy link

Sven-TBD commented Jun 6, 2024

image What should be displayed here when the transaction is neither isomorphic transaction or unlock transaction? @Sven-TBD

Normally, this wont happen when this is a RGB++ Transaction.
However, we can still handle this case by display nothing.

@FrederLu
Copy link

FrederLu commented Jun 6, 2024

image

1、Please follow the prd document for RGB++ attribute text. At the same time, the L1 ->L2 icon is missing next to RGB++ Digest.

the L1 ->L2 icon is missing next to RGB++ Digest This problem still exists.

3、The RGB++ attribute on the xudt list/Address shows unusual data.
4、Bitcoin TX: data is displayed repeatedly.
5、Data entered as btc time lock is missing attributes and L1->L2 icon.

These issues remain to be addressed.
@Daryl-L

@Daryl-L
Copy link
Author

Daryl-L commented Jun 7, 2024

image > 1、Please follow the prd document for RGB++ attribute text. At the same time, the L1 ->L2 icon is missing next to RGB++ Digest.

the L1 ->L2 icon is missing next to RGB++ Digest This problem still exists.

3、The RGB++ attribute on the xudt list/Address shows unusual data.
4、Bitcoin TX: data is displayed repeatedly.
5、Data entered as btc time lock is missing attributes and L1->L2 icon.

These issues remain to be addressed.

  1. Data from API is null, how to display?
  2. Should we remove the confirmation blocks and block time from the right side? @Sven-TBD
  3. According to the data from API, it is not an RGB++ transaction @Sven-TBD please check if it isn't a RGB++ transaction, how to display?

@FrederLu
Copy link

FrederLu commented Jun 7, 2024

3.Data from API is null, how to display?

image

Through the requirement on prd, the page does not display the label when null is returned. cc @Sven-TBD

@Daryl-L
Copy link
Author

Daryl-L commented Jun 7, 2024

3.Data from API is null, how to display?

image Through the requirement on prd, the page does not display the label when null is returned. cc @Sven-TBD

The first condition shows if it was not a RGB++ transaction, but actually, it is.

@Daryl-L
Copy link
Author

Daryl-L commented Jun 7, 2024

image What should be displayed here when the transaction is neither isomorphic transaction or unlock transaction? @Sven-TBD

Normally, this wont happen when this is a RGB++ Transaction. However, we can still handle this case by display nothing.

I just missed this comment, did you mean that we should not display the whole tag when it is null, even though it is a RGB++ transaction?

@Sven-TBD
Copy link

Sven-TBD commented Jun 7, 2024

image What should be displayed here when the transaction is neither isomorphic transaction or unlock transaction? @Sven-TBD

Normally, this wont happen when this is a RGB++ Transaction. However, we can still handle this case by display nothing.

I just missed this comment, did you mean that we should not display the whole tag when it is null, even though it is a RGB++ transaction?

Yes, we can do this first.

@Sven-TBD
Copy link

Sven-TBD commented Jun 7, 2024

image
Sorry, Let's just keep the back one

@Sven-TBD
Copy link

Sven-TBD commented Jun 7, 2024

@Daryl-L I found the API has been fixed by Nan, could you please fix this when you are free as well?
image
image

"withinBTC" : " L1 -> L1"
"in":" L1 -> L2", which you have already finished .

@FrederLu
Copy link

2024-06-13.12.06.29.mov

https://ckb-explorer-frontend-in-magickbase-repo-okomdwwgi-magickbase.vercel.app/transaction/0xd36d39eb0144a0135b21a2fdd5227b99bc6d2fc0d9d707c215e4e3fe1d585a52
image
image

The label on the side of RGB++ Digest lacks the Hover prompt information. At the same time, there are now 2 labels, and the lower ones need to be hidden.
Labels are also required next to RGB++ Digest on the list page to avoid duplication.

@Daryl-L
Copy link
Author

Daryl-L commented Jun 13, 2024

2024-06-13.12.06.29.mov
https://ckb-explorer-frontend-in-magickbase-repo-okomdwwgi-magickbase.vercel.app/transaction/0xd36d39eb0144a0135b21a2fdd5227b99bc6d2fc0d9d707c215e4e3fe1d585a52 image image

The label on the side of RGB++ Digest lacks the Hover prompt information. At the same time, there are now 2 labels, and the lower ones need to be hidden. Labels are also required next to RGB++ Digest on the list page to avoid duplication.

I didn't get it from the draft, maybe it is not updated yet. Could you please make some confirmation? @Sven-TBD

@Sven-TBD
Copy link

ima@Daryl-L @Daryl-L @Kirl70 Currently, there're 2 labels here, I guess we can just remove the below one, and remain the one next to the title.

@Kirl70
Copy link

Kirl70 commented Jun 13, 2024

The label on the side of RGB++ Digest lacks the Hover prompt information. At the same time, there are now 2 labels, and the lower ones need to be hidden. Labels are also required next to RGB++ Digest on the list page to avoid duplication.

The design draft has been updated, and the labels are now aligned next to the RGB++ Digest.
https://www.figma.com/design/6XNoimRDbFTTNm016rbIdU/Magickbase?node-id=35067-23136&t=lGCoipesjyYjIWSO-1
image

@FrederLu
Copy link

5、Data entered as btc time lock is missing attributes and L1->L2 icon.

The problem still exists. Data involving BTC Time Lock needs to be processed Magickbase/ckb-explorer-public-issues#698 first.


https://ckb-explorer-frontend-in-magickbase-repo-okomdwwgi-magickbase.vercel.app/transaction/0x9099747a27e3e4f5064c211a0192323b2268d26044a81369fff51df9e77666f3
image

"leap_direction": The data for "leapoutBTC" is missing RGB++ tags.

@Daryl-L
Copy link
Author

Daryl-L commented Jun 19, 2024

5、Data entered as btc time lock is missing attributes and L1->L2 icon.

The problem still exists. Data involving BTC Time Lock needs to be processed Magickbase/ckb-explorer-public-issues#698 first.

https://ckb-explorer-frontend-in-magickbase-repo-okomdwwgi-magickbase.vercel.app/transaction/0x9099747a27e3e4f5064c211a0192323b2268d26044a81369fff51df9e77666f3 image

"leap_direction": The data for "leapoutBTC" is missing RGB++ tags.

added

@Keith-CY Keith-CY merged commit c65f7c1 into develop Jun 19, 2024
8 checks passed
@Keith-CY Keith-CY deleted the feature/l1-l2 branch June 19, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants