-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: highlight search input result keyword #263
feat: highlight search input result keyword #263
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
The search results are provided by the backend, and the matching fields include "description", and I'm guessing "USD" is included in "description". This pr is matching that string and highlighting it in the frontend, I can change it if it means that the frontend doesn't want to highlight |
But in this case |
Any update on this |
fixed it |
Please have a review @FrederLu |
Magickbase/ckb-explorer-public-issues#511 (comment) When the mouse is hovering, in addition to the matching information being highlighted, other information does not need to be highlighted. The red line in the screenshot should be highlighted (the first point of the match), but it is not, while the later points are. The data in the search results box is abnormal. Name information that matches the input information should be displayed, with matching data highlighted. If there is no corresponding data match, the data should not be displayed in the result information. |
Problems 1 and 2 have been fixed, regarding the last two points, the search results are returned by the back-end, if want to change the search fields and logic, may need to collaborate with the back-end developers. |
f2bfdd6
to
af2a202
Compare
The fixed problem will be verified later, but now the page cannot be opened, please confirm.
Using the API of |
The display logic for previous searches was the same, About search results, most search engines support many fields, it seems to me that searching for both |
af2a202
to
508f83e
Compare
resolve: Magickbase/ckb-explorer-public-issues#511