Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Windows support #62

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Implement Windows support #62

wants to merge 13 commits into from

Conversation

1st1
Copy link
Member

@1st1 1st1 commented Nov 23, 2016

To-do:

  • test_create_connection_ssl_1 hangs
  • a bunch of DNS tests fail (likely different error messages)
  • one of UDP tests is failing

Major things:

  • Implement a separate handles/process.pyx for Windows which would use only standard libuv APIs for stdin/out/err.
  • Need new uv_udp_connect() API for proper UDP support.

External PRs:

@1st1
Copy link
Member Author

1st1 commented Nov 26, 2017

Rebased agains the current master branch.

@ahartikainen
Copy link

Hi, what is the current situation with Windows support?

Is the problem with msvc and if so, could mingw64-w64 used to circumvent those problems?

I'am happy to help, but not sure where to start.

ps We are using this package with https://github.com/stan-dev/httpstan

@ma5oud180
Copy link

Hi Yuri, I understand that you are super busy, but I myself & as I see lots of people, are not able and have not the skills to make it work on Windows. I would like to kindly ask you to finally, easily make it possible to install this package on Windows 64 bit systems. Lots of people are looking for it. Thanks

@1st1
Copy link
Member Author

1st1 commented Apr 17, 2019

Lots of people are looking for it.

Maybe, but there's no good reason for that. Do you have a good reason?

Vanilla asyncio works perfectly fine on Windows, there's no benefit of running uvloop except better performance. And not that many people deploy Python on Windows these days. Besides, Windows now has Linux subsystem, you can run uvloop there.

Porting uvloop to Windows is also blocked on libuv -- there's a bunch of work we need to do there (libuv) before we can do it here (uvloop). Doing this properly is a multi-week project that I don't have time to do now for free.

@1st1
Copy link
Member Author

1st1 commented Apr 17, 2019

@ahartikainen

I'am happy to help, but not sure where to start.

A good start would be to rebase this PR on top of the latest master branch. I'd then spend some time to merge a half-featured Windows support so that it's in the master branch and requires CI. We can slowly start improving Windows support from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants