-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to customize options for floating windows #300
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lervag Thank you for your contribution! 😄
Please see my comments for some minor changes that should be done.
Ideally should also add some tests to tests/base/test_ui.lua
where you override some option like the border and assert that the screenshot is correct. Tests use mini.test
. Check out https://github.com/MagicDuck/grug-far.nvim/blob/main/CONTRIBUTING.md for how to run them via the command line.
ff453d9
to
7d32039
Compare
Thanks for the good and useful comments; I've updated the code accordingly. I believe it should be quite good now.
I made a minimal test right now. Not sure if it is sufficient here, but at least it's something that we can discuss. |
7d32039
to
9925882
Compare
9925882
to
c272db2
Compare
Looks good! That test you added would be sufficient for the help window case. If you can, add similar tests for the history and preview windows. |
c272db2
to
e4a3311
Compare
Ok, I've added additional tests now. Please check if the tests are up to your standards here - the test framework is unfamiliar to me, so I may have misunderstood something. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! Thanks for patiently implementing all my suggestions! :)
This is a first attempt at addressing #299; it is probably not perfect and may (will) need some work.
Let me know what you think!