-
Notifications
You must be signed in to change notification settings - Fork 115
How To Submit a Pull Request
First of all thank you for contributing back to the project, collaboration is the lifeblood of open source projects.
A pull request is GitHub's mechanism for submitting patches to a project. They have some excellent help articles on how to create one:
- https://help.github.com/articles/creating-a-pull-request
- https://help.github.com/articles/using-pull-requests
In order to create a clean pull request that can me merged automatically (the best kind!) there are a few things you should keep in mind:
This is the most important point. Don't conflate multiple issues into one pull request, create separate requests and make sure that each one stands on its own.
This includes reformatting whitespace, changes to unrelated parts of the code, debug print statements, and so on.
Be mindful to follow the same style for indentation, naming, casing, and quoting.
Development might be happening in a feature branch at the moment, or in a branch preparing for a point release. Check the current branches and their latest commits.
For bug small bug fixes feel free to create a pull request straight away, but please file an issue before implementing new features or perform any major undertakings.
Avoid commits with descriptions like "Fixes", "WIP", or "Forgot to add foo.py". They're fine in your local repository, but rebase before creating the pull request.