Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show coverage of the Changed Files (Diff) #56

Merged
merged 56 commits into from
Jul 30, 2023
Merged

Show coverage of the Changed Files (Diff) #56

merged 56 commits into from
Jul 30, 2023

Conversation

thsaravana
Copy link
Member

@thsaravana thsaravana commented Jul 30, 2023 •
edited
Loading

Fixes #25

In addition to the Overall coverage, now the action also shows the Diff of just the changes introduced in the PR.

Added screenshots to the README.md.
Tested for both Single and Multi module. Ref: thsaravana/jacoco-android-playground#11 (comment) and thsaravana/jacoco-playground#23 (comment)

thsaravana added 30 commits July 25, 2023 18:00
@thsaravana
Checking information exposed by github for the changed files
fbf44d6
@thsaravana
Updating the index.js
65aed59
@thsaravana
Finding the modified line numbers from the patch
a0bbe47
@thsaravana
Logging the changedLines
d05649b
@thsaravana
Modifying the changedLines logs
a029169
@thsaravana
Finished the logic to get changed line numbers for files
54679a2
@thsaravana
Updating all tests
fb1a964
@thsaravana
Parsing line coverage information from jacoco report
4450f08
@thsaravana
Sharing constants between tests
1458800
@thsaravana
Making process.js use getFilesWithCoverage but with same functionality
bde288d
@thsaravana
Adding line information to the result files
100fdbb
@thsaravana
Adding line number to the line object
86fce62
@thsaravana
Adding coverageDifference to Files Table
cd7af53
@thsaravana
Building index.js
a7bc731
@thsaravana
Fixing the 'instruction' undefined issue
3b505e8
@thsaravana
Experimenting with design for the coverage diff
ffed36d
@thsaravana
Removing the parenthesis for the coverage diff element
339a8be
@thsaravana
Left align the Coverage column
9965b6a
@thsaravana
Remove the coverage information from column header
b13366d
@thsaravana
Updating TestData (tests are not yet updated)
aa6c173
@thsaravana
Fixed tests
ae7998b
@thsaravana
Fixed more tests
c3a2512
@thsaravana
Logging patch to test
8454d36
@thsaravana
Fixing all tests
60a9684
@thsaravana
Adding coverage diff for module table
2ec30e3
@thsaravana
Updating tests
777bc36
@thsaravana
Refactoring
60b5a17
@thsaravana
Correcting the module coverage diff
2140236
@thsaravana
Adding coverage diff to project table
55bd567
@thsaravana
Coverage diff percentage was not multiplied by 100
cd506c3
thsaravana added 23 commits July 28, 2023 23:12
@thsaravana
Fixing the status hide logic for all rows
15e7995
@thsaravana
Revert "Fixing the status hide logic for all rows"
a5b5171 
This reverts commit 15e7995.
@thsaravana
Revert "Show status column only if min-coverage input is available"
a3102e3 
This reverts commit 9905a6c.
@thsaravana
Update default value of the min coverage
0a82dd5
@thsaravana
Using coverageDiff for status calculation in Files Table
da02741
@thsaravana
Using coverageDiff for status calculation in Modules Table
9a0454b
@thsaravana
Adding the Changed Files row
6749d07
@thsaravana
Update README.md
d1d6c28
@thsaravana
Adding space between overallTable and the following table
67b213a
@thsaravana
Removed the getOverallCoverage method
035f463
@thsaravana
Refactor: Added overall block at project level
5cd65b2
@thsaravana
Refactor: Added overall block at module level
7d2cfcd
@thsaravana
Refactor: Added overall block at file level
f5fba2d
@thsaravana
Refactor: Added changed block at file level
9422502
@thsaravana
Refactor: Added changed block at module level
f979b32
@thsaravana
Refactor: Added changed block at project level
e3819ac
@thsaravana
Refactor: Removed sumReducer logic in render.js
f6edea3
@thsaravana
Content rename
c0f00e7
@thsaravana
Refactor: Passing minCoverage object to getPRComment
d0e894c
@thsaravana
Using changedFiles coverage instead of the dip for calculating status
6dd8f9d
@thsaravana
Updating screenshots
b4b5c58
@thsaravana
Update README.md
d3ffb59
@thsaravana
Update README.md
15abe19
@thsaravana thsaravana added this to the 1.6 milestone Jul 30, 2023
@thsaravana thsaravana added the feature request New feature or request label Jul 30, 2023
@thsaravana thsaravana self-assigned this Jul 30, 2023
@thsaravana thsaravana requested a review from instrap July 30, 2023 13:29
instrap
instrap approved these changes Jul 30, 2023
View reviewed changes
Copy link
Member

@instrap instrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be for 1.7 milestone, we can create a release_v1.7 branch and treat that as the base branch. Let's keep main branch in sync with the latest released version. This is just to keep the README.md match, the code itself don't pose any problem.

@thsaravana thsaravana merged commit 963d839 into main Jul 30, 2023
@thsaravana thsaravana deleted the coverage-diff branch July 30, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@instrap instrap instrap approved these changes

Assignees

@thsaravana thsaravana

Labels
feature request New feature or request
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.

Coverage diff - source vs target
2 participants
@thsaravana @instrap