Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate dependency_links unless --use-dependency-links specified #62

Closed
wants to merge 1 commit into from

Conversation

jbraswell
Copy link
Contributor

Pip removed support for dependency_links in 19.0 (pypa/pip#6060). This PR modifies the sync command to write dependencies to install_requires using PEP 508 URLs, unless --use-dependency-links is specified.

@codecov-commenter
Copy link

codecov-commenter commented May 7, 2021

Codecov Report

Merging #62 (3b4c469) into master (2b66c23) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
+ Coverage   94.63%   94.70%   +0.07%     
==========================================
  Files          10       10              
  Lines         745      756      +11     
==========================================
+ Hits          705      716      +11     
  Misses         40       40              
Impacted Files Coverage Δ
pipenv_setup/lockfile_parser.py 94.00% <100.00%> (+0.66%) ⬆️
pipenv_setup/main.py 94.85% <100.00%> (+0.03%) ⬆️
pipenv_setup/pipfile_parser.py 89.39% <100.00%> (+0.86%) ⬆️
pipenv_setup/setup_parser.py 88.57% <100.00%> (+1.42%) ⬆️
pipenv_setup/setup_updater.py 96.82% <0.00%> (-0.80%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b66c23...3b4c469. Read the comment docs.

@jbraswell
Copy link
Contributor Author

Closed in favor of #64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants