Conversation
Member
frapac
commented
Nov 10, 2021
- MadNLPGraph is not yet compatible with JuMP 0.22
- MINLPTests's tests have been commented out: they are passing, but MINLPTests requires JuMP 0.22 too
Member
Author
|
For MINLPTests: jump-dev/MINLPTests.jl#34 |
Member
Author
|
|
Contributor
|
Just a notice that we will release JuMP v1.0 in a few days |
Member
Author
|
Thanks for the reminder! This PR is ready to merge, we can make a new release for MadNLP with MOI 1.0 in the next few days. |
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
==========================================
- Coverage 87.55% 81.33% -6.22%
==========================================
Files 31 31
Lines 3382 3392 +10
==========================================
- Hits 2961 2759 -202
- Misses 421 633 +212
Continue to review full report at Codecov.
|
Member
Author
|
Finally, tests are passing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.