Added ToricHigherDirectImages package #3720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-torrance
requested changes
Apr 2, 2025
| Headline => "computations involving pushforwards and higher direct images of toric maps", | ||
| DebuggingMode => false, | ||
| PackageExports => {"NormalToricVarieties","Complexes"}, | ||
| PackageImports => {"FourierMotzkin"} |
Member
There was a problem hiding this comment.
Thanks for the contribution!
The test builds are failing because each package should have at least one keyword, ideally chosen from the list of headings in the packages provided with Macaulay2 documentation node.
These are given as an option to newPackage, e.g.,:
newPackage("
"ToricHigherDirectImage",
...
Keywords => {"Toric Geometry"},
...
Contributor
Author
|
Oops, thanks Doug! Hopefully all of the checks pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ToricHigherDirectImages package, which is for computing higher direct images of line bundles under toric morphisms, as well as pushforwards of toric Frobenius maps.