-
Notifications
You must be signed in to change notification settings - Fork 264
Add ring and promote methods for Constant objects #3457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
366739d to
8d5df65
Compare
Contributor
|
looking good. it still misses some cases, though maybe we're reaching the limit of the |
Add support for creating matrices with Constant entries. Also add a unit test.
8d5df65 to
22a7ca4
Compare
Member
Author
|
That case was straightforward enough. I added i1 : map(CC[x],CC[y,z],{x,ii})
o1 = map (CC [x], CC [y..z], {x, ii})
53 53
o1 : RingMap CC [x] <-- CC [y..z]
53 53 |
pzinn
approved these changes
Sep 6, 2024
d-torrance
added a commit
to d-torrance/M2
that referenced
this pull request
Mar 5, 2025
* 0-atomic-ops-mac-os-x (now using C standard library atomics)
* 0-bugs/ggsmith.m2 (there's now a LocalRings package)
* 0-completion-for-packages (this has been the case for some time)
* 0-delete-error-message ("delete" is now a method)
* 0-doc (fixed at some point -- bug no longer present)
* 0-export-strings ("export" has been accepting only string since 2014)
* 0-factory ("libcfmem" is old -- we can link against factory w/o problems)
* 0-factory-depends (refers to nonexistent file)
* 0-merge-1.5 (merged in 2013! see 5088768)
* 0-ubuntu-dpkg-triggers (distributions/deb package is deprecated)
* 0-update-gpl-license-version (mentioned in LICENSING-NOTES)
* 0-Verbosity (duplicate of Macaulay2#273)
* 0.1-error-message (now get a "no method found" error)
* 0.1-xemacs (xemacs is essentially dead)
* 0.5-debian-script (distributions/deb package is deprecated)
* 0.5-fix-M2-exec-location (fixed by Macaulay2#2163)
* 0.5-package-finding-programs (fixed when "findProgram" was added)
* 0.5-ubuntu-repository (M2 has been in Debian/Ubuntu since 2020)
* 0.7-selectPairs (selectPairs implemented in Macaulay2#3305)
* 1-apropos (can use regex, e.g., apropos "(?i)sort")
* 1-code-and-hooks (implemented in Macaulay2#3118)
* 1-constant-to-RR (promote works since Macaulay2#3457, toRR is compiled so wontfix)
* 1-debian-changelog-file (distributions/deb package is deprecated)
* 1-deb-signatures (distributions/deb package is deprecated)
* 1-factory-bug (bug not present using factory from singular 4.3.2)
* 1-GPL (we added GPL 3 some time ago)
* 1-include-applications (this has been the behavior for some time)
* 1-Kronecker (added in 2010 -- see d1cb81c)
* 1-nextPrime (added in 2016 -- see 992b43f)
* 1-recursion-in-printing (no more recursion error -- now "no method found")
[ci skip]
d-torrance
added a commit
to d-torrance/M2
that referenced
this pull request
Mar 5, 2025
* 0-atomic-ops-mac-os-x (now using C standard library atomics)
* 0-bugs/ggsmith.m2 (there's now a LocalRings package)
* 0-completion-for-packages (this has been the case for some time)
* 0-delete-error-message ("delete" is now a method)
* 0-doc (fixed at some point -- bug no longer present)
* 0-export-strings ("export" has been accepting only string since 2014)
* 0-factory ("libcfmem" is old -- we can link against factory w/o problems)
* 0-factory-depends (refers to nonexistent file)
* 0-merge-1.5 (merged in 2013! see 5088768)
* 0-ubuntu-dpkg-triggers (distributions/deb package is deprecated)
* 0-update-gpl-license-version (mentioned in LICENSING-NOTES)
* 0-Verbosity (duplicate of Macaulay2#273)
* 0.1-error-message (now get a "no method found" error)
* 0.1-xemacs (xemacs is essentially dead)
* 0.5-debian-script (distributions/deb package is deprecated)
* 0.5-fix-M2-exec-location (fixed by Macaulay2#2163)
* 0.5-package-finding-programs (fixed when "findProgram" was added)
* 0.5-ubuntu-repository (M2 has been in Debian/Ubuntu since 2020)
* 0.7-selectPairs (selectPairs implemented in Macaulay2#3305)
* 1-apropos (can use regex, e.g., apropos "(?i)sort")
* 1-code-and-hooks (implemented in Macaulay2#3118)
* 1-constant-to-RR (promote works since Macaulay2#3457, toRR is compiled so wontfix)
* 1-debian-changelog-file (distributions/deb package is deprecated)
* 1-deb-signatures (distributions/deb package is deprecated)
* 1-factory-bug (bug not present using factory from singular 4.3.2)
* 1-fflas (FFLAS-FFPACK added in 2011 -- see e50558b)
* 1-fpLLL (fpLLL added in 2013 -- see 2447204)
* 1-GPL (we added GPL 3 some time ago)
* 1-include-applications (this has been the behavior for some time)
* 1-Kronecker (added in 2010 -- see d1cb81c)
* 1-nextPrime (added in 2016 -- see 992b43f)
* 1-recursion-in-printing (no more recursion error -- now "no method found")
[ci skip]
d-torrance
added a commit
to d-torrance/M2
that referenced
this pull request
Mar 12, 2025
* 0-atomic-ops-mac-os-x (now using C standard library atomics)
* 0-bugs/ggsmith.m2 (there's now a LocalRings package)
* 0-completion-for-packages (this has been the case for some time)
* 0-delete-error-message ("delete" is now a method)
* 0-doc (fixed at some point -- bug no longer present)
* 0-export-strings ("export" has been accepting only string since 2014)
* 0-factory ("libcfmem" is old -- we can link against factory w/o problems)
* 0-factory-depends (refers to nonexistent file)
* 0-merge-1.5 (merged in 2013! see 5088768)
* 0-ubuntu-dpkg-triggers (distributions/deb package is deprecated)
* 0-update-gpl-license-version (mentioned in LICENSING-NOTES)
* 0-Verbosity (duplicate of Macaulay2#273)
* 0.1-error-message (now get a "no method found" error)
* 0.1-xemacs (xemacs is essentially dead)
* 0.5-debian-script (distributions/deb package is deprecated)
* 0.5-fix-M2-exec-location (fixed by Macaulay2#2163)
* 0.5-package-finding-programs (fixed when "findProgram" was added)
* 0.5-ubuntu-repository (M2 has been in Debian/Ubuntu since 2020)
* 0.7-selectPairs (selectPairs implemented in Macaulay2#3305)
* 1-apropos (can use regex, e.g., apropos "(?i)sort")
* 1-code-and-hooks (implemented in Macaulay2#3118)
* 1-constant-to-RR (promote works since Macaulay2#3457, toRR is compiled so wontfix)
* 1-debian-changelog-file (distributions/deb package is deprecated)
* 1-deb-signatures (distributions/deb package is deprecated)
* 1-factory-bug (bug not present using factory from singular 4.3.2)
* 1-fflas (FFLAS-FFPACK added in 2011 -- see e50558b)
* 1-fpLLL (fpLLL added in 2013 -- see 2447204)
* 1-GPL (we added GPL 3 some time ago)
* 1-include-applications (this has been the behavior for some time)
* 1-Kronecker (added in 2010 -- see d1cb81c)
* 1-nextPrime (added in 2016 -- see 992b43f)
* 1-recursion-in-printing (no more recursion error -- now "no method found")
* 2-freeaddrinfo (fixed in 2009 -- see a107aeb)
[ci skip]
d-torrance
added a commit
to d-torrance/M2
that referenced
this pull request
Mar 20, 2025
* 0-atomic-ops-mac-os-x (now using C standard library atomics)
* 0-bugs/ggsmith.m2 (there's now a LocalRings package)
* 0-completion-for-packages (this has been the case for some time)
* 0-delete-error-message ("delete" is now a method)
* 0-doc (fixed at some point -- bug no longer present)
* 0-export-strings ("export" has been accepting only string since 2014)
* 0-factory ("libcfmem" is old -- we can link against factory w/o problems)
* 0-factory-depends (refers to nonexistent file)
* 0-getPackage-and-DOS (getPackage was removed)
* 0-gmp-as-mpir (we no longer link against MPIR)
* 0-hash-task (tasks now use nextHash)
* 0-merge-1.5 (merged in 2013! see 5088768)
* 0-ubuntu-dpkg-triggers (distributions/deb package is deprecated)
* 0-update-gpl-license-version (mentioned in LICENSING-NOTES)
* 0-Verbosity (duplicate of Macaulay2#273)
* 0.1-error-message (now get a "no method found" error)
* 0.1-xemacs (xemacs is essentially dead)
* 0.5-debian-script (distributions/deb package is deprecated)
* 0.5-fix-M2-exec-location (fixed by Macaulay2#2163)
* 0.5-package-finding-programs (fixed when "findProgram" was added)
* 0.5-ubuntu-repository (M2 has been in Debian/Ubuntu since 2020)
* 0.7-selectPairs (selectPairs implemented in Macaulay2#3305)
* 1-apropos (can use regex, e.g., apropos "(?i)sort")
* 1-code-and-hooks (implemented in Macaulay2#3118)
* 1-constant-to-RR (promote works since Macaulay2#3457, toRR is compiled so wontfix)
* 1-debian-changelog-file (distributions/deb package is deprecated)
* 1-deb-signatures (distributions/deb package is deprecated)
* 1-factory-bug (bug not present using factory from singular 4.3.2)
* 1-fflas (FFLAS-FFPACK added in 2011 -- see e50558b)
* 1-fpLLL (fpLLL added in 2013 -- see 2447204)
* 1-getPackage (getPackage was removed)
* 1-GPL (we added GPL 3 some time ago)
* 1-include-applications (this has been the behavior for some time)
* 1-Kronecker (added in 2010 -- see d1cb81c)
* 1-nextPrime (added in 2016 -- see 992b43f)
* 1-recursion-in-printing (no more recursion error -- now "no method found")
* 2-freeaddrinfo (fixed in 2009 -- see a107aeb)
[ci skip]
d-torrance
added a commit
that referenced
this pull request
Nov 7, 2025
* 0-atomic-ops-mac-os-x (now using C standard library atomics)
* 0-bugs/ggsmith.m2 (there's now a LocalRings package)
* 0-completion-for-packages (this has been the case for some time)
* 0-delete-error-message ("delete" is now a method)
* 0-doc (fixed at some point -- bug no longer present)
* 0-export-strings ("export" has been accepting only string since 2014)
* 0-factory ("libcfmem" is old -- we can link against factory w/o problems)
* 0-factory-depends (refers to nonexistent file)
* 0-getPackage-and-DOS (getPackage was removed)
* 0-gmp-as-mpir (we no longer link against MPIR)
* 0-hash-task (tasks now use nextHash)
* 0-merge-1.5 (merged in 2013! see 5088768)
* 0-ubuntu-dpkg-triggers (distributions/deb package is deprecated)
* 0-update-gpl-license-version (mentioned in LICENSING-NOTES)
* 0-Verbosity (duplicate of #273)
* 0.1-error-message (now get a "no method found" error)
* 0.1-xemacs (xemacs is essentially dead)
* 0.5-debian-script (distributions/deb package is deprecated)
* 0.5-fix-M2-exec-location (fixed by #2163)
* 0.5-package-finding-programs (fixed when "findProgram" was added)
* 0.5-ubuntu-repository (M2 has been in Debian/Ubuntu since 2020)
* 0.7-selectPairs (selectPairs implemented in #3305)
* 1-apropos (can use regex, e.g., apropos "(?i)sort")
* 1-code-and-hooks (implemented in #3118)
* 1-constant-to-RR (promote works since #3457, toRR is compiled so wontfix)
* 1-debian-changelog-file (distributions/deb package is deprecated)
* 1-deb-signatures (distributions/deb package is deprecated)
* 1-factory-bug (bug not present using factory from singular 4.3.2)
* 1-fflas (FFLAS-FFPACK added in 2011 -- see e50558b)
* 1-fpLLL (fpLLL added in 2013 -- see 2447204)
* 1-getPackage (getPackage was removed)
* 1-GPL (we added GPL 3 some time ago)
* 1-include-applications (this has been the behavior for some time)
* 1-Kronecker (added in 2010 -- see d1cb81c)
* 1-nextPrime (added in 2016 -- see 992b43f)
* 1-recursion-in-printing (no more recursion error -- now "no method found")
* 2-freeaddrinfo (fixed in 2009 -- see a107aeb)
[ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for creating matrices with Constant entries. Also add a unit test.
Before
After
Closes: #3456