Add "ForeignStructType ForeignObject" method #3034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we added "ForeignStructType HashTable", it overwrote the "ForeignType ForeignObject" method since ForeignObject inherits from HashTable. This caused problems when dealing with foreign struct objects (for example, an RInterface test was failing).
|
@DanGrayson @mikestillman Would either of you be willing to merge this soon to fix the builds on the other PR's? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we added
ForeignStructType HashTable, it overwrote theForeignType ForeignObjectmethod sinceForeignObjectinherits fromHashTable. This caused problems when dealing with foreign struct objects (for example, anRInterfacetest was failing).This fixes the build error noted in #3022 (comment).