Fix the issue where it does not decode the Error correctly when streaming response #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
gavtron2000
approved these changes
Aug 17, 2023
|
Hey @Krivoblotsky, can you merge this? |
|
Yup, will add it to the release scope 👌 |
|
@Krivoblotsky Also do you think we should switch to a new implementation. I find the current one quite problematic. For example, this issue: #97 Another issue I encountered is when working with OpenAI-compatible services, they might use SSE comments (started with |
|
Actually, can I add the fix to this PR and we can review + merge it instead of another PR? :D |
|
@longseespace let's do it with separate PR to reduce changes size plz 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
When using streaming, there might be an error occurring in the middle of the streaming.
This PR fixes it.
Previous PR: #87
Why
Related: #88
Affected Areas
StreamingSession.swift