Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt streaming in Demo app #59

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Conversation

DJBen
Copy link
Contributor

@DJBen DJBen commented Apr 19, 2023

What

Adopt streaming in demo app, and add a model switcher between gpt3 and 4 models.

DemoAppStreaming.mov

Why

Demo app will be broken if this doesn't come in. Also I think this is how people want to use the API primarily.

Affected Areas

Demo app.

@rotemdoron
Copy link

any plan to include this?

@DJBen
Copy link
Contributor Author

DJBen commented Apr 20, 2023

@rotemdoron I do. Ultimately I defer to @Krivoblotsky

@Krivoblotsky
Copy link
Collaborator

I’m ok to merge it into the streaming branch, however, I’m gonna run more tests before merging streaming branch itself to handle some corner cases.

@Krivoblotsky Krivoblotsky merged commit 5ad6ae3 into MacPaw:streaming Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants