Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add streaming session and ability to use streaming #57
Add streaming session and ability to use streaming #57
Changes from 6 commits
ac668b7
37a5e73
f9b5cde
1d03919
ffa609f
0c16d1e
04cf5ba
5ad6ae3
79fb479
3b639e0
8a8aafd
4854390
e612b6b
db71d79
c82c55e
0258524
bb9e8f9
9f7610c
6bb1456
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to mix the complete and partial results, can you comment in what condition these properties are
nil
?I have moderate preference in separating a complete
Choice
from aPartialChoice
, provided that they have major differences, despite the official OpenAI API mix them together.As a result, the result can contain enum of either
Choice
orPartialChoice
What do you think? Appreciated!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've decided to keep
ChatResult
to not break backward compatibility and created "ChatStreamingResult" along with a separate function for streaming. I found this solution more straightforward and clean. What do you think about this?