Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Parameter Update #169

Merged
merged 6 commits into from
Feb 15, 2024
Merged

Conversation

kalafus
Copy link
Contributor

@kalafus kalafus commented Feb 7, 2024

What

  • add missing API parameters
  • add, update parameter descriptions
  • update any deprecated functions parameters to corresponding replacement tools parameters
  • use enums to emulate python API type unions for full parameter type support

Why

structs are out of sync with API

Affected Areas

Response and Query structs

James J Kalafus added 3 commits February 5, 2024 16:20
…ns > tools), add and update parameter descriptions, use enums to emulate python API type unions for full parameter type support
Copy link
Contributor

@ingvarus-bc ingvarus-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @kalafus, thank you for your contribution! You did such an impressive huge job, well done! 🔥🤩

Only one little thing, I'd like to comment, I see _(underscore) format in lots of places, usually when working with Swift it is common and kind of style guide rule, to use CamelCase. Not a dealbreaker, but would be great if everything there was in one consistent style.

Copy link

sonarcloud bot commented Feb 15, 2024

Quality Gate Passed Quality Gate passed

Issues
30 New issues

Measures
0 Security Hotspots
No data about Coverage
1.0% Duplication on New Code

See analysis details on SonarCloud

@ingvarus-bc
Copy link
Contributor

Thanks a lot! 🔥

@ingvarus-bc ingvarus-bc merged commit 224f4ef into MacPaw:main Feb 15, 2024
4 checks passed
@kalafus kalafus mentioned this pull request Feb 15, 2024
kalafus pushed a commit to kalafus/OpenAI that referenced this pull request Feb 16, 2024
tisfeng pushed a commit to tisfeng/OpenAI that referenced this pull request May 11, 2024
vishnuravi pushed a commit to StanfordBDHG/OpenAI that referenced this pull request May 15, 2024
vandyshev pushed a commit to vandyshev/OpenAI that referenced this pull request Jun 19, 2024
* macpaw/main:
  Adds gpt-4o
  Fixes the `m4a` content type sent as `mp4` instead
  Update Models.swift
  gpt-4-vision-preview support fix and test MacPaw#169 MacPaw#174
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants