-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify OpenAI.performRequest #135
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @rchatham!
Thanks for your Pull Request and interest in the project!
I love the approach and how much simpler it became 🔥
Made just a couple comments to fix minor errors in the code, as they just wouldn't let it build and they're basically a compiler errors.
|
@ingvarus-bc I updated this PR some time ago, what do you think about merging? |
Thanks for your contribution, @rchatham! |
What
Increases the readability of
performRequest
,performSpeechRequest
, andprocessJSON
.Why
Readability and simplicity.
Affected Areas
OpenAI.swift