Simplify OpenAI.performRequest #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ingvarus-bc
suggested changes
Dec 22, 2023
There was a problem hiding this comment.
Hi, @rchatham!
Thanks for your Pull Request and interest in the project!
I love the approach and how much simpler it became 🔥
Made just a couple comments to fix minor errors in the code, as they just wouldn't let it build and they're basically a compiler errors.
|
|
@ingvarus-bc I updated this PR some time ago, what do you think about merging? |
ingvarus-bc
approved these changes
Feb 2, 2024
|
Thanks for your contribution, @rchatham! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Increases the readability of
performRequest,performSpeechRequest, andprocessJSON.Why
Readability and simplicity.
Affected Areas
OpenAI.swift