Improvements for the connect server ip resolve #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The same logic should be added to the chat server as well, but in a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We always have the issue that the server doesn't magically work after it has been installed. One major thing is that the game client gets disconnected after selecting a server in the server list.
I had the idea that, if the client connects, we can look at the Socket.LocalEndPoint to which IP it initially connected. If the ip address of the connect server is the same as the ip of the choosen game server we can assume that the client has also access to the game server by connecting to the same ip address.
Probably needs some additional tests for the different scenarios, so I leave it as draft for now.