Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PVP option to GameServerDefinition and AdminPanel #483

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

nReCon
Copy link
Contributor

@nReCon nReCon commented Sep 2, 2024

This adds the ability to toggle PVP on individual game servers.
PVP is enabled by default as that's the default behavior of OpenMU before this change.

I'm not sure how battle zones should be handled.
This PR allows them on non-PVP servers, let me know if this shouldn't be the case.

This is my first PR for this project, and this is also my first time using C#, so please let me know if I'm doing something wrong here.

It also adds a checkbox in the admin panel:
image

@sven-n
Copy link
Member

sven-n commented Sep 2, 2024

Thanks, it looks very good!
One thing is missing: A migration for the entity framework ;-)
See also https://github.com/MUnique/OpenMU/blob/master/src/Persistence/EntityFramework/Migrations/Cheatsheet.md

Add migration for PvpEnabled
@nReCon
Copy link
Contributor Author

nReCon commented Sep 2, 2024

I've added the migration, and I set the default value to true as well because apparently I forgot to do that originally.

@sven-n
Copy link
Member

sven-n commented Sep 3, 2024

Thanks, it looks perfect!

@sven-n sven-n merged commit 6f38b88 into MUnique:master Sep 3, 2024
2 checks passed
@nReCon nReCon deleted the pvp-option-2 branch September 3, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants