Make Degara beattracker deterministic #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Other candidate algorithms to check for same behaviour:
|
|
Thanks for this fix! Noise can be added to silent frames only in the streaming version of FrameCutter. For that reason, there's no problem for TempoTapDegara. We'll have to check the other ones. |
|
Indeed BeatTrackerMultifeature also utilizes noise frames for silence, but I can't reproduce the problem. |
dbogdanov
requested changes
May 24, 2019
.gitignore
Outdated
| @@ -84,3 +84,9 @@ packaging/win32_3rdparty/bin | |||
| packaging/win32_3rdparty/share | |||
| packaging/win32_3rdparty/lib | |||
| packaging/win32_3rdparty/include | |||
| test/src/unittest/*.npy | |||
There was a problem hiding this comment.
This should be updated because all tests were moved to the unittestsfolder.
There was a problem hiding this comment.
In any case, we should rather not generate junk files inside test/src/unit test, but use a proper temp folder instead. I've created an issue for that (#861), so we can remove tose ignore lines here.
jpauwels
force-pushed
the
deterministic-tempo
branch
from
e4ac739
to
ff01169
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make Degara beattracker deterministic by not adding stochastic noise to silent frames