Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new algo pitch2midi #1423

Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open

Conversation

xaviliz
Copy link
Contributor

@xaviliz xaviliz commented Jun 19, 2024

This pull request add the new essentia algorithm pitch2midi and its corresponding unittests.

Copy link
Member

@dbogdanov dbogdanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review (to be continued)

src/algorithms/tonal/pitch2midi.h Outdated Show resolved Hide resolved
src/algorithms/tonal/pitch2midi.h Outdated Show resolved Hide resolved
src/algorithms/tonal/pitch2midi.h Outdated Show resolved Hide resolved
src/algorithms/tonal/pitch2midi.h Outdated Show resolved Hide resolved
src/algorithms/tonal/pitch2midi.h Outdated Show resolved Hide resolved
src/algorithms/tonal/pitch2midi.h Outdated Show resolved Hide resolved
src/algorithms/tonal/pitch2midi.cpp Outdated Show resolved Hide resolved
src/algorithms/tonal/pitch2midi.cpp Show resolved Hide resolved
src/algorithms/tonal/pitch2midi.cpp Outdated Show resolved Hide resolved
src/algorithms/tonal/pitch2midi.cpp Show resolved Hide resolved
@xaviliz
Copy link
Contributor Author

xaviliz commented Jul 2, 2024

Changes are done, the review can continue

@xaviliz xaviliz closed this Jul 16, 2024
@xaviliz xaviliz reopened this Jul 16, 2024
@xaviliz xaviliz marked this pull request as ready for review July 16, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants