Add essentiamath #1417
Merged
Add essentiamath #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbogdanov
requested changes
May 27, 2024
src/essentia/essentiamath.h
Outdated
Comment on lines
741
to
746
| inline Real cents2hz(Real frequencyB, Real cents) { | ||
| return frequencyB * powf(2.0, cents / 1200.0); | ||
| } | ||
|
|
||
| inline Real hz2cents(Real frequencyA, Real frequencyB) { | ||
| return 1200 * log2(frequencyA / frequencyB); |
There was a problem hiding this comment.
frequencyA vs frequencyB can be unclear to users. Maybe we could use a different naming for frequencyB like referenceFrequency?
There was a problem hiding this comment.
Sure, that makes sense. I doubted with tuningFrequency but referenceFrequency works better. Thanks.
src/essentia/essentiamath.h
Outdated
| int noteIdx = floor((octave - (CIdx + 1)) * nNotes); | ||
| int idx = 0; | ||
| for (int i = 0; i < nNotes; i++) { | ||
| if (ALL_NOTES[i] == root) { |
There was a problem hiding this comment.
Break out of the loop once the matching note is found.
There was a problem hiding this comment.
L796 is doing it by index. However it can be replaced by a break to make it more explicit. Thanks again to point it out.
src/python/globalfuncs.cpp
Outdated
| @@ -1001,6 +1162,18 @@ static PyMethodDef Essentia__Methods[] = { | |||
| { "hz2bark", hzToBark, METH_O, "Converts a frequency in Hz to a bark band" }, | |||
| { "mel2hz", melToHz, METH_O, "Converts a mel band to frequency in Hz" }, | |||
| { "hz2mel", hzToMel, METH_O, "Converts a frequency in Hz to a mel band" }, | |||
| { "midi2hz", midiToHz, METH_VARARGS, "Converts a midi note number to frequency in Hz" }, | |||
| { "hz2midi", hzToMidi, METH_VARARGS, "Converts a frequency in Hz to a midi note number" }, | |||
| { "hz2cents", hzToCents, METH_VARARGS, "Returns the cents distance between two frequencies in Hz" }, | |||
There was a problem hiding this comment.
if we use the referenceFrequency (see my comment about), we should updates this description too.
src/python/globalfuncs.cpp
Outdated
| vector<PyObject*> argsV = unpack(args); | ||
|
|
||
| if (argsV.size() != 2 || !PyFloat_Check(argsV[0]) || !PyFloat_Check(argsV[1])) { | ||
| PyErr_SetString(PyExc_TypeError, (char*)"expecting arguments (Real frequencyA, Real frequencyB)"); |
src/python/globalfuncs.cpp
Outdated
| vector<PyObject*> argsV = unpack(args); | ||
|
|
||
| if (argsV.size() != 2 || !PyFloat_Check(argsV[0]) || !PyFloat_Check(argsV[1])) { | ||
| PyErr_SetString(PyExc_TypeError, (char*)"expecting arguments (Real frequencyB, Real cents)"); |
|
Thanks for the corrections and comments 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some hertz, midi note number and note conversions: