Documenting work done on pitch contour tests #1164
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to allow Cherry Picking work done on PitchContour testing.
Adding a Unit Test that was worked on in closed "unmerged" branch
#1121.
Most of the issues have been dealt with. The way "continuity" is tested has not yet been checked.
This Unit Test is in the same "family" of testing as pitch salience tests (and psf peaks), so the testing strategy here needs to be aligned (e.g. they should be checked for similarity and test coverage ideas ) with those Unit Tests which are now merged (pitchsaliencefunction and pitchsaliencefunctionpeaks)
There are 5 test cases altogether:
Empty
EmptyFrames
InvalidParam
RegressionSynthetic
UnequalInputs