Updates to superflux extractor (e.g RegTest, invalid vals, etc.) #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbogdanov
requested changes
Feb 8, 2021
| self.assertAlmostEqual(found[i], expected[j-1], precision) | ||
| else: | ||
| self.assertAlmostEqual(found[i], expected[j], precision) | ||
|
|
||
| def testSilence(self): | ||
| # zeros should return no onsets (empty array) | ||
| self.assertEqualMatrix(SuperFluxExtractor()(zeros(44100)), []) |
There was a problem hiding this comment.
The output is 1-D vector, so we can use assertEqualVector instead.
There was a problem hiding this comment.
self.assertEqualMatrix should use self.assertEqualVector
| @@ -55,7 +103,6 @@ def testImpulse(self): | |||
| precission = (hopSize + frameSize) / sampleRate | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Regression Tests based on two audio files, whose values were captured on previous runs with the same parameters.
Tested on Ubuntu and Linux Subsystem on Windows.
Superfluxextractor covers peaks and novelty tests internally.
Dummies added to maintain 1:1 correspondence between src, file and UT.