-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use elm-watch #160
Use elm-watch #160
Conversation
So, this is now working correctly, BUT:
In the current context, I'd say that elm-watch works well, but esbuild is less than ideal (at least for now, for us). |
… in an attempt to fix scalingo deployment
Ok, this should now be up for review @n1k0 , would you like to take it for a spin? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really cool to see elm-watch used together with Vite!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several remarks at this point:
- Port used for dev server is 5173; this should be updated in README (or couldn't we juyst set it up to use 1234 as before?)
elm-watch
seems young and promising, but also prone to changes in a near future; wouldn't we want it to settle a little before leveraging it in production?- The API page is broken
- matter of personal taste, but I really appreciated the all-inclusive, configuration-less approach of Parcel; in this patch, I find the configuration files are a little hard to understand
@@ -7,12 +7,12 @@ | |||
/public/icomoon/*.txt | |||
/public/icomoon/*.zip | |||
/public/icomoon/demo-files | |||
/public/icomoon/demo-files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why removing this line? We don't want to version icomoon HTML demo files…
"start:parcel": "parcel serve index.html --no-cache", | ||
"start:dev": "npm run build:init && concurrently -n \"watch,parcel,server\" -c \"green,cyan\" \"npm run start:parcel\" \"npm run server:dev\"", | ||
"start": "PARCEL_ELM_NO_DEBUG=1 npm run start:dev", | ||
"start": "run-pty run-pty.json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, running this command doesn't tell me at what URL the app is served; we should also document this in README (yes navigating helps, but it's easier if the user already knows)
- `VITE_SENTRY_DSN`: le DSN [Sentry](https://sentry.io) à utiliser pour les rapports d'erreur. | ||
- `VITE_MATOMO_TOKEN`: le token [Matomo](https://stats.data.gouv.fr/) permettant le suivi d'audience de l'API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: It's annoying these must be prefixed; no way to avoid it?
Worked on it for 1.5 years, used it in production for 5 months. No changes are planned, only enhancements. |
This branch has diverged much while we'r epretty much happy with Parcel atm, so I'm gonna close this one. |
Replace parcel with elm-watch
TODO:
MATOMO_TOKEN
->VITE_MATOMO_TOKEN